[SPARK-9103][WIP] Track Netty memory usage - take two #17762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual pull of the PR from: https://github.com/apache/spark/pull/7753/commits Created with: git checkout upstream/pr/7753 -- . A bunch of manual merging happened after this.
Refactor MemoryListener to core from UI.
|
Jenkins, ok to test |
|
Test build #76148 has finished for PR 17762 at commit
|
|
Jenkins, retest this please |
|
Test build #76197 has finished for PR 17762 at commit
|
|
To close the loop here: I'm going to rework these ideas into a new JIRA that I'll file, to track total memory usage in the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resurrects #7753 by liyezhang556520 and #17625 by jsoltren.
What changes were proposed in this pull request?
Memory reporting is a much desired feature in Apache Spark. This change adds reporting for some memory used by netty. We introduce a new executorMetrics object to track this.
This is a backend only change. No UI is included with this change.
How was this patch tested?
Ran https://github.com/jsoltren/spark-demos/blob/master/src/main/scala/org/soltren/spark/examples/ShuffleGroupCount.scala