Skip to content

Commit 550c2d8

Browse files
committed
Remove UI parts of this change set
Refactor MemoryListener to core from UI.
1 parent f3d8aa5 commit 550c2d8

File tree

7 files changed

+5
-320
lines changed

7 files changed

+5
-320
lines changed

core/src/main/scala/org/apache/spark/ui/memory/MemoryTab.scala renamed to core/src/main/scala/org/apache/spark/memory/MemoryListener.scala

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,14 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.spark.ui.memory
18+
package org.apache.spark.memory
1919

2020
import scala.collection.mutable.HashMap
2121

2222
import org.apache.spark.annotation.DeveloperApi
2323
import org.apache.spark.executor.{ExecutorMetrics, TransportMetrics}
2424
import org.apache.spark.scheduler._
2525
import org.apache.spark.scheduler.cluster.ExecutorInfo
26-
import org.apache.spark.ui.{SparkUI, SparkUITab}
27-
28-
private[ui] class MemoryTab(parent: SparkUI) extends SparkUITab(parent, "memory") {
29-
val memoryListener = parent.memoryListener
30-
val progressListener = parent.jobProgressListener
31-
attachPage(new MemoryPage(this))
32-
attachPage(new StageMemoryPage(this))
33-
}
3426

3527
/**
3628
* :: DeveloperApi ::

core/src/main/scala/org/apache/spark/ui/SparkUI.scala

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import org.apache.spark.ui.JettyUtils._
3131
import org.apache.spark.ui.env.{EnvironmentListener, EnvironmentTab}
3232
import org.apache.spark.ui.exec.{ExecutorsListener, ExecutorsTab}
3333
import org.apache.spark.ui.jobs.{JobProgressListener, JobsTab, StagesTab}
34-
import org.apache.spark.ui.memory.{MemoryListener, MemoryTab}
3534
import org.apache.spark.ui.scope.RDDOperationGraphListener
3635
import org.apache.spark.ui.storage.{StorageListener, StorageTab}
3736
import org.apache.spark.util.Utils
@@ -48,7 +47,6 @@ private[spark] class SparkUI private (
4847
val executorsListener: ExecutorsListener,
4948
val jobProgressListener: JobProgressListener,
5049
val storageListener: StorageListener,
51-
val memoryListener: MemoryListener,
5250
val operationGraphListener: RDDOperationGraphListener,
5351
var appName: String,
5452
val basePath: String,
@@ -73,7 +71,6 @@ private[spark] class SparkUI private (
7371
attachTab(new StorageTab(this))
7472
attachTab(new EnvironmentTab(this))
7573
attachTab(new ExecutorsTab(this))
76-
attachTab(new MemoryTab(this))
7774
attachHandler(createStaticHandler(SparkUI.STATIC_RESOURCE_DIR, "/static"))
7875
attachHandler(createRedirectHandler("/", "/jobs/", basePath = basePath))
7976
attachHandler(ApiRootResource.getServletHandler(this))
@@ -213,18 +210,16 @@ private[spark] object SparkUI {
213210
val storageStatusListener = new StorageStatusListener(conf)
214211
val executorsListener = new ExecutorsListener(storageStatusListener, conf)
215212
val storageListener = new StorageListener(storageStatusListener)
216-
val memoryListener = new MemoryListener
217213
val operationGraphListener = new RDDOperationGraphListener(conf)
218214

219215
listenerBus.addListener(environmentListener)
220216
listenerBus.addListener(storageStatusListener)
221217
listenerBus.addListener(executorsListener)
222218
listenerBus.addListener(storageListener)
223-
listenerBus.addListener(memoryListener)
224219
listenerBus.addListener(operationGraphListener)
225220

226221
new SparkUI(sc, conf, securityManager, environmentListener, storageStatusListener,
227-
executorsListener, _jobProgressListener, storageListener, memoryListener,
228-
operationGraphListener, appName, basePath, startTime)
222+
executorsListener, _jobProgressListener, storageListener, operationGraphListener,
223+
appName, basePath, startTime)
229224
}
230225
}

core/src/main/scala/org/apache/spark/ui/memory/MemoryPage.scala

Lines changed: 0 additions & 109 deletions
This file was deleted.

core/src/main/scala/org/apache/spark/ui/memory/MemoryTable.scala

Lines changed: 0 additions & 143 deletions
This file was deleted.

core/src/main/scala/org/apache/spark/ui/memory/StageMemoryPage.scala

Lines changed: 0 additions & 52 deletions
This file was deleted.

core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import org.apache.spark._
3131
import org.apache.spark.deploy.SparkHadoopUtil
3232
import org.apache.spark.internal.Logging
3333
import org.apache.spark.io._
34+
import org.apache.spark.memory.{MemoryListener, MemTime}
3435
import org.apache.spark.util.{JsonProtocol, Utils}
3536

3637
/**

core/src/test/scala/org/apache/spark/ui/memory/MemoryListenerSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package org.apache.spark.ui.memory
1919

2020
import org.apache.spark._
2121
import org.apache.spark.executor._
22+
import org.apache.spark.memory.{MemoryListener, MemTime, TransportMemSize}
2223
import org.apache.spark.scheduler._
2324
import org.apache.spark.scheduler.cluster._
2425

0 commit comments

Comments
 (0)