Skip to content

optimize: fix go vet issue #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2025
Merged

optimize: fix go vet issue #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a80087e
fix go vet
slievrly Sep 24, 2025
9f1d83f
Merge branch 'master' into master_25_09_24
Code-Fight Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/datasource/sql/datasource/base/meta_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ func (m *mockTrigger) LoadAll(ctx context.Context, dbName string, conn *sql.Conn

func TestBaseTableMetaCache_refresh(t *testing.T) {
type fields struct {
lock sync.RWMutex
expireDuration time.Duration
capity int32
size int32
Expand All @@ -96,7 +95,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
{
name: "test1",
fields: fields{
lock: sync.RWMutex{},
capity: capacity,
size: 0,
expireDuration: EexpireTime,
Expand All @@ -117,7 +115,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
{
name: "test2",
fields: fields{
lock: sync.RWMutex{},
capity: capacity,
size: 0,
expireDuration: EexpireTime,
Expand Down Expand Up @@ -154,7 +151,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
defer loadAllStub.Reset()

c := &BaseTableMetaCache{
lock: tt.fields.lock,
expireDuration: tt.fields.expireDuration,
capity: tt.fields.capity,
size: tt.fields.size,
Expand Down
10 changes: 5 additions & 5 deletions pkg/datasource/sql/exec/at/base_executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ func TestBaseExecBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test_name",
Rows: []types.RowImage{
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "user1")}},
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "user2")}},
{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "user1")}},
{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "user2")}},
},
},
"TEST_NAME:1_user1,2_user2",
Expand All @@ -84,9 +84,9 @@ func TestBaseExecBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test2_name",
Rows: []types.RowImage{
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
{[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
{Columns: []types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
},
},
"TEST2_NAME:1_one_11,2_two_22,3_three_33",
Expand Down
10 changes: 5 additions & 5 deletions pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ func TestBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test_name",
Rows: []types.RowImage{
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one")}},
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two")}},
{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one")}},
{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two")}},
},
},
"TEST_NAME:1_one,2_two",
Expand All @@ -110,9 +110,9 @@ func TestBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test2_name",
Rows: []types.RowImage{
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
{[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
{Columns: []types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
},
},
"TEST2_NAME:1_one_11,2_two_22,3_three_33",
Expand Down
Loading