Skip to content

Conversation

slievrly
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #889

go vet ./...

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added coding bug Something isn't working labels Sep 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.17%. Comparing base (f6da25c) to head (9f1d83f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   38.17%   38.17%           
=======================================
  Files         188      188           
  Lines       11417    11417           
=======================================
  Hits         4359     4359           
  Misses       6628     6628           
  Partials      430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Go vet issues by correcting struct literal syntax and removing unused fields. The changes ensure the code follows proper Go conventions and passes static analysis checks.

  • Fixed struct literal initializations to use named field syntax
  • Removed unused lock field from test structs
  • Updated test cases to use proper Go struct initialization patterns

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go Fixed RowImage struct literals to use named Columns field
pkg/datasource/sql/exec/at/base_executor_test.go Fixed RowImage struct literals to use named Columns field
pkg/datasource/sql/datasource/base/meta_cache_test.go Removed unused lock field from test struct definitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexStocks AlexStocks merged commit a1816a9 into apache:master Sep 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go vet issue
4 participants