Skip to content

UI: Add cluster arch type to the zone creation wizard #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2025
Merged

UI: Add cluster arch type to the zone creation wizard #10080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7a04b7
UI: Add cluster arch type to the zone creation wizard
nvazquez Dec 11, 2024
a645fea
Remove unused field
nvazquez Dec 11, 2024
ad57a39
Fix github lint action
nvazquez Dec 12, 2024
44db249
Remove unused option key
nvazquez Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ui/src/views/infra/zone/ZoneWizardAddResources.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,13 @@ export default {
placeHolder: 'message.error.cluster.name',
required: true
},
{
title: 'label.arch',
key: 'arch',
required: false,
select: true,
options: this.architectureTypes
},
{
title: 'label.vcenter.host',
key: 'vCenterHost',
Expand Down Expand Up @@ -846,6 +853,13 @@ export default {
primaryStorageScopes: [],
primaryStorageProtocols: [],
primaryStorageProviders: [],
architectureTypes: [{
id: 'x86_64',
description: 'AMD 64 bits (x86_64)'
}, {
id: 'aarch64',
description: 'ARM 64 bits (aarch64)'
}],
storageProviders: [],
currentStep: null,
options: ['primaryStorageScope', 'primaryStorageProtocol', 'provider', 'primaryStorageProvider']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez
I see you removed archTypes from line 865.
is architectureTypes needed in the options ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed @weizhouapache

Expand Down
1 change: 1 addition & 0 deletions ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,6 +1283,7 @@ export default {
if (this.isEdgeZone) {
clusterName = 'Cluster-' + this.stepData.zoneReturned.name
}
params.arch = this.prefillContent?.arch || null

if (hypervisor === 'VMware') {
params.username = this.prefillContent?.vCenterUsername || null
Expand Down
Loading