Skip to content

UI: Add cluster arch type to the zone creation wizard #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 2, 2025
Merged

UI: Add cluster arch type to the zone creation wizard #10080

merged 4 commits into from
Jan 2, 2025

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Dec 11, 2024 •
edited
Loading

Description

This PR adds the arch type on the cluster creation step on the zone creation wizard.

Screenshot 2024-12-10 at 23 01 03

Fixes: #10014

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally KVM on ARM nested virtualization on UTM 4.6.3 on macOs:

  • On the cluster step: selected ARM 64
  • On the host step: entered the ARM host information
  • Result: Zone successfully created

How did you try to break this feature and the system with this change?

@nvazquez nvazquez mentioned this pull request Dec 11, 2024
Closed
@nvazquez
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.03%. Comparing base (e57a82a) to head (44db249).
Report is 21 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10080   +/-   ##
=========================================
  Coverage     16.03%   16.03%           
  Complexity    12814    12814           
=========================================
  Files          5637     5637           
  Lines        493506   493507    +1     
  Branches      59831    59832    +1     
=========================================
+ Hits          79129    79130    +1     
  Misses       405601   405601           
  Partials       8776     8776
Flag Coverage Δ
uitests 4.02% <ø> (-0.01%) ⬇️
unittests 16.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10080 (QA-JID-499)

weizhouapache
weizhouapache reviewed Dec 11, 2024
View reviewed changes
@DaanHoogland DaanHoogland linked an issue Dec 11, 2024 that may be closed by this pull request
Cloudstack 4.20 - Configuration Wizard fails on aarch64 host (management server and kvm host) #10014
Closed
BryanMLima
BryanMLima approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@BryanMLima BryanMLima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@nvazquez nvazquez added this to the 4.20.1 milestone Dec 12, 2024
weizhouapache
weizhouapache reviewed Dec 12, 2024
View reviewed changes
ui/src/views/infra/zone/ZoneWizardAddResources.vue
}, {
id: 'aarch64',
description: 'ARM 64 bits (aarch64)'
}],
storageProviders: [],
currentStep: null,
options: ['primaryStorageScope', 'primaryStorageProtocol', 'provider', 'primaryStorageProvider']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez
I see you removed archTypes from line 865.
is architectureTypes needed in the options ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed @weizhouapache

JoaoJandre
JoaoJandre approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@andrijapanicsb
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@andrijapanicsb
Copy link
Contributor

(just testing BO due to lab upgrades)

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10080 (QA-JID-503)

@rohityadavcloud rohityadavcloud merged commit 3d0b4fc into apache:4.20 Jan 2, 2025
26 checks passed
DaanHoogland added a commit that referenced this pull request Jan 3, 2025
@DaanHoogland
Merge release branch 4.20 to main
30b2588 
* 4.20:
  log name change after merge forward
  check tags while fetching storage pool for importing vm (#9764)
  UI: Add cluster arch type to the zone creation wizard (#10080)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 10, 2025
@nvazquez @dhslove
UI: Add cluster arch type to the zone creation wizard (apache#10080)
53cdbb3 
* UI: Add cluster arch type to the zone creation wizard

* Remove unused field

* Fix github lint action

* Remove unused option key
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
@longxiaotian799 longxiaotian799 mentioned this pull request Jul 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache left review comments

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@BryanMLima BryanMLima BryanMLima approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@NuxRo NuxRo Awaiting requested review from NuxRo

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees
No one assigned
Labels
component:UI
Projects
ACS 4.20.1
Status: Done
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.

Cloudstack 4.20 - Configuration Wizard fails on aarch64 host (management server and kvm host)
8 participants
@nvazquez @blueorangutan @andrijapanicsb @rohityadavcloud @DaanHoogland @BryanMLima @JoaoJandre @weizhouapache