Skip to content

sdk: Refactor Rentsysvar #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
febo merged 9 commits into from
Dec 17, 2025
Merged

sdk: Refactor Rentsysvar #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
efaad10
Remove f64 references for upstream bpf
febo Dec 5, 2025
1d823f9
Fix review comments
febo Dec 6, 2025
57e1bf3
Revert to u64 values
febo Dec 7, 2025
ef65bef
Add cfg for f64 constant
febo Dec 7, 2025
eb6d8da
Back to arrays
febo Dec 10, 2025
2671ac7
Add maximum data_len check
febo Dec 12, 2025
e472f45
Fix typos
febo Dec 15, 2025
36cada6
Fix review comments
febo Dec 17, 2025
3544047
Add clippy note
febo Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion programs/system/src/instructions/create_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ impl<'a> CreateAccount<'a> {
owner: &'a Address,
) -> Result<Self, ProgramError> {
let rent = Rent::from_account_view(rent_sysvar)?;
let lamports = rent.minimum_balance(space as usize);
let lamports = rent.try_minimum_balance(space as usize)?;

Ok(Self {
from,
Expand Down
2 changes: 1 addition & 1 deletion programs/system/src/instructions/create_account_with_seed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ impl<'a, 'b, 'c> CreateAccountWithSeed<'a, 'b, 'c> {
owner: &'c Address,
) -> Result<Self, ProgramError> {
let rent = Rent::from_account_view(rent_sysvar)?;
let lamports = rent.minimum_balance(space as usize);
let lamports = rent.try_minimum_balance(space as usize)?;

Ok(Self {
from,
Expand Down
4 changes: 2 additions & 2 deletions programs/system/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ pub fn create_account_with_minimum_balance_signed(
) -> ProgramResult {
let lamports = if let Some(rent_sysvar) = rent_sysvar {
let rent = Rent::from_account_view(rent_sysvar)?;
rent.minimum_balance(space)
rent.try_minimum_balance(space)?
} else {
Rent::get()?.minimum_balance(space)
Rent::get()?.try_minimum_balance(space)?
};

if account.lamports() == 0 {
Expand Down
1 change: 1 addition & 0 deletions scripts/setup/solana.dic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,4 @@ mainnet
getters
PRNG
middleware
MiB
Loading