sdk: Refactor Rentsysvar
#294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
commented
Dec 5, 2025
febo
force-pushed
the
febo/upstream-rent
branch
2 times, most recently
from
812d444 to
37d9cc7
Compare
febo
force-pushed
the
febo/upstream-rent
branch
from
37d9cc7 to
efaad10
Compare
joncinque
reviewed
Dec 5, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just one question about the target_os = solana part, the rest looks great!
febo
force-pushed
the
febo/upstream-rent
branch
from
9bb767d to
4146158
Compare
febo
force-pushed
the
febo/upstream-rent
branch
from
4146158 to
1d823f9
Compare
joncinque
previously approved these changes
Dec 6, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just the bit about saturating math, but we can address later
febo
commented
Dec 7, 2025
joncinque
reviewed
Dec 8, 2025
febo
force-pushed
the
febo/upstream-rent
branch
from
0cba916 to
2dcc702
Compare
febo
force-pushed
the
febo/upstream-rent
branch
from
2dcc702 to
2671ac7
Compare
joncinque
reviewed
Dec 15, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Mostly just bits about overflowing due to a huge lamports_per_byte, everything else looks good!
joncinque
reviewed
Dec 16, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
A few more ideas, let me know what you think! Maybe I'm too focused on silly usage of Rent, but it doesn't feel good to provide a try_ function in an SDK that could overflow
febo
commented
Dec 17, 2025
febo
force-pushed
the
febo/upstream-rent
branch
from
6acecdc to
36cada6
Compare
joncinque
reviewed
Dec 17, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
One last thing, and we can land this!
joncinque
approved these changes
Dec 17, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great, thanks for all the revisions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The concept of rent no longer exists, only rent-exemption, and upstream BPF does not support
f64values but currently theRentsysvar implementation uses them.Solution
Refactor the sysvar implementation and remove all references to
f64.