This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(build): properly filter core module files with updated gulp-filter #9399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
type: build
needs: review
* After an update to the new `gulp-filter` major version (without any changelog) it seems that `gulp-filter` can no longer match files (which aren't at the root level) This new behavior makes completely sense, and the old one was not valid. > Previous Version: `*.css` matches `src/core/core.css | src/core/core-default-theme.css` > New Version: `*.css` matches no files, because at the project root are no CSS files. * Now using multi level globs to match the core module files properly, because those are not at the root level (`src/core/`).
devversion
force-pushed
the
fix/gulp-if-breaking-changes
branch
from
a2bc1c9 to
dab991e
Compare
|
@devversion - lgtm |
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an update to the new
gulp-filtermajor version (without any changelog)it seems that
gulp-filtercan no longer match files (which aren't at the root level)This new behavior makes completely sense, and the old one was not valid.
Now using multi level globs to match the core module files properly, because those are not at the root level (but
src/core/).