Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 0cd2a59

Browse files
devversionjelbourn
authored andcommitted
fix(build): properly filter core module files with updated gulp-filter (#9399)
* After an update to the new `gulp-filter` major version (without any changelog) it seems that `gulp-filter` can no longer match files (which aren't at the root level) This new behavior makes completely sense, and the old one was not valid. > Previous Version: `*.css` matches `src/core/core.css | src/core/core-default-theme.css` > New Version: `*.css` matches no files, because at the project root are no CSS files. * Now using multi level globs to match the core module files properly, because those are not at the root level (`src/core/`).
1 parent f265a0e commit 0cd2a59

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

gulp/util.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,12 @@ function buildModule(module, opts) {
122122

123123
function splitStream (stream) {
124124
var js = series(stream, themeBuildStream())
125-
.pipe(filter('*.js'))
125+
.pipe(filter('**/*.js'))
126126
.pipe(concat('core.js'));
127-
var css = stream.pipe(filter('*.css'));
127+
128+
var css = stream
129+
.pipe(filter(['**/*.css', '!**/ie_fixes.css']))
130+
128131
return series(js, css);
129132
}
130133

0 commit comments

Comments
 (0)