This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(mdPanel): Wrapper and Panel elements referenced in the MdPanelRef #9231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -214,6 +214,12 @@ angular | |||
| * create. | |||
| * - `isAttached` - `{boolean}`: Whether the panel is attached to the DOM. | |||
| * Visibility to the user does not factor into isAttached. | |||
| * - `panelContainer` - `{angular.JQLite}`: The wrapper element containing the | |||
There was a problem hiding this comment.
@ErinCoughlan Not sure if you saw these earlier, but just wanted to make sure.
|
@ErinCoughlan Are you thinking that I should add back in the |
|
@ErinCoughlan that's a good idea.. that way we can make sure it's not breaking anyone |
|
@bradrich @EladBezalel After some thought, I think we should follow the real deprecation strategy here. We don't want to break people and we want to give them some time to migrate to the new methods.
|
|
@ErinCoughlan I agree with this and will move forward with the changes. |
A JQLite reference of the Container/Wrapper and Panel elements have been added to the MdPanelRef object as public properties. It is now possible to use the standard `addClass`, `removeClass`, `toggleClass`, etc methods on those referenced elements. Fixes angular#9109 Ping @ErinCoughlan
bradrich
force-pushed
the
feat/panel-element-reference
branch
from
3d4876d to
a7d6ea6
Compare
|
@ErinCoughlan Please take a look at the newest commit that contains the deprecation notices and warnings. |
| 'The addClass method is in the process of being deprecated. ' + | ||
| 'Full deprecation is scheduled for the Angular Material 1.2 release. ' + | ||
| 'To achieve the same results, use the panelContainer or panelEl ' + | ||
| 'JQLite elements that are referenced in MdPanelRef.'); |
There was a problem hiding this comment.
I would almost even write the line to replace this one to make it even easier. Not strictly required though.
|
LGTM |
|
@bradrich can you open an issue at 1.2 milestone so we can keep track of this deprecation ? |
ThomasBurleson
added
pr: merge ready
Splaktar
added a commit
that referenced
this pull request
Jul 26, 2020
…ggleClass - deprecated in 2016 in favor of using the `panelContainer` or `panelEl` JQLite elements that are referenced in the MdPanelRef object. - more details in #9231 (comment) Fixes #9310 BREAKING CHANGE: The deprecated `MdPanelRef.addClass()`, `MdPanelRef.removeClass()`, and `MdPanelRef.toggleClass()` functions have been removed. These were deprecated in 2016 in favor of using the `panelContainer` or `panelEl` JQLite elements that are referenced in the [MdPanelRef](https://material.angularjs.org/latest/api/type/MdPanelRef) object. squash! refactor(tabs): remove deprecated md-no-disconnect
Splaktar
added a commit
that referenced
this pull request
Jul 27, 2020
…ggleClass - deprecated in 2016 in favor of using the `panelContainer` or `panelEl` JQLite elements that are referenced in the MdPanelRef object. - more details in #9231 (comment) Fixes #9310 BREAKING CHANGE: The deprecated `MdPanelRef.addClass()`, `MdPanelRef.removeClass()`, and `MdPanelRef.toggleClass()` functions have been removed. These were deprecated in 2016 in favor of using the `panelContainer` or `panelEl` JQLite elements that are referenced in the [MdPanelRef](https://material.angularjs.org/latest/api/type/MdPanelRef) object. squash! refactor(tabs): remove deprecated md-no-disconnect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A JQLite reference of the Container/Wrapper and Panel elements have been added to the MdPanelRef object as public properties. It is now possible to use the standard
addClass,removeClass,toggleClass, etc methods on those referenced elements.Fixes #9109