Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit bafbd96

Browse files
SplaktarSplaktar
committed
refactor(panel): remove deprecated MdPanelRef.addClass/removeClass/toggleClass
- deprecated in 2016 in favor of using the `panelContainer` or `panelEl` JQLite elements that are referenced in the MdPanelRef object. - more details in #9231 (comment) Fixes #9310 BREAKING CHANGE: The deprecated `MdPanelRef.addClass()`, `MdPanelRef.removeClass()`, and `MdPanelRef.toggleClass()` functions have been removed. These were deprecated in 2016 in favor of using the `panelContainer` or `panelEl` JQLite elements that are referenced in the [MdPanelRef](https://material.angularjs.org/latest/api/type/MdPanelRef) object. squash! refactor(tabs): remove deprecated md-no-disconnect
1 parent 05bee8f commit bafbd96

File tree

1 file changed

+1
-139
lines changed

1 file changed

+1
-139
lines changed

‎src/components/panel/panel.js

Lines changed: 1 addition & 139 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ angular
272272
* called after the close successfully finishes. The first parameter passed
273273
* into this function is the current panelRef and the 2nd is an optional
274274
* string explaining the close reason. The currently supported closeReasons
275-
* can be found in the MdPanelRef.closeReasons enum. These are by default
275+
* can be found in the `MdPanelRef.closeReasons` enum. These are by default
276276
* passed along by the panel.
277277
* - `trapFocus` - `{boolean=}`: Whether focus should be trapped within the
278278
* panel. If `trapFocus` is true, the user will not be able to interact
@@ -459,51 +459,6 @@ angular
459459
* Destroys the panel. The panel cannot be opened again after this is called.
460460
*/
461461

462-
/**
463-
* @ngdoc method
464-
* @name MdPanelRef#addClass
465-
* @deprecated
466-
* This method is in the process of being deprecated in favor of using the panel
467-
* and container JQLite elements that are referenced in the MdPanelRef object.
468-
* Full deprecation is scheduled for material 1.2.
469-
* @description
470-
* Adds a class to the panel. DO NOT use this hide/show the panel.
471-
*
472-
* @param {string} newClass class to be added.
473-
* @param {boolean} toElement Whether or not to add the class to the panel
474-
* element instead of the container.
475-
*/
476-
477-
/**
478-
* @ngdoc method
479-
* @name MdPanelRef#removeClass
480-
* @deprecated
481-
* This method is in the process of being deprecated in favor of using the panel
482-
* and container JQLite elements that are referenced in the MdPanelRef object.
483-
* Full deprecation is scheduled for material 1.2.
484-
* @description
485-
* Removes a class from the panel. DO NOT use this to hide/show the panel.
486-
*
487-
* @param {string} oldClass Class to be removed.
488-
* @param {boolean} fromElement Whether or not to remove the class from the
489-
* panel element instead of the container.
490-
*/
491-
492-
/**
493-
* @ngdoc method
494-
* @name MdPanelRef#toggleClass
495-
* @deprecated
496-
* This method is in the process of being deprecated in favor of using the panel
497-
* and container JQLite elements that are referenced in the MdPanelRef object.
498-
* Full deprecation is scheduled for material 1.2.
499-
* @description
500-
* Toggles a class on the panel. DO NOT use this to hide/show the panel.
501-
*
502-
* @param {string} toggleClass Class to be toggled.
503-
* @param {boolean} onElement Whether or not to remove the class from the panel
504-
* element instead of the container.
505-
*/
506-
507462
/**
508463
* @ngdoc method
509464
* @name MdPanelRef#updatePosition
@@ -1732,99 +1687,6 @@ MdPanelRef.prototype.hide = function() {
17321687
});
17331688
};
17341689

1735-
/**
1736-
* Add a class to the panel. DO NOT use this to hide/show the panel.
1737-
* @deprecated
1738-
* This method is in the process of being deprecated in favor of using the panel
1739-
* and container JQLite elements that are referenced in the MdPanelRef object.
1740-
* Full deprecation is scheduled for material 1.2.
1741-
*
1742-
* @param {string} newClass Class to be added.
1743-
* @param {boolean} toElement Whether or not to add the class to the panel
1744-
* element instead of the container.
1745-
*/
1746-
MdPanelRef.prototype.addClass = function(newClass, toElement) {
1747-
this._$log.warn(
1748-
'mdPanel: The addClass method is in the process of being deprecated. ' +
1749-
'Full deprecation is scheduled for the AngularJS Material 1.2 release. ' +
1750-
'To achieve the same results, use the panelContainer or panelEl ' +
1751-
'JQLite elements that are referenced in MdPanelRef.');
1752-
1753-
if (!this.panelContainer) {
1754-
throw new Error(
1755-
'mdPanel: Panel does not exist yet. Call open() or attach().');
1756-
}
1757-
1758-
if (!toElement && !this.panelContainer.hasClass(newClass)) {
1759-
this.panelContainer.addClass(newClass);
1760-
} else if (toElement && !this.panelEl.hasClass(newClass)) {
1761-
this.panelEl.addClass(newClass);
1762-
}
1763-
};
1764-
1765-
1766-
/**
1767-
* Remove a class from the panel. DO NOT use this to hide/show the panel.
1768-
* @deprecated
1769-
* This method is in the process of being deprecated in favor of using the panel
1770-
* and container JQLite elements that are referenced in the MdPanelRef object.
1771-
* Full deprecation is scheduled for material 1.2.
1772-
*
1773-
* @param {string} oldClass Class to be removed.
1774-
* @param {boolean} fromElement Whether or not to remove the class from the
1775-
* panel element instead of the container.
1776-
*/
1777-
MdPanelRef.prototype.removeClass = function(oldClass, fromElement) {
1778-
this._$log.warn(
1779-
'mdPanel: The removeClass method is in the process of being deprecated. ' +
1780-
'Full deprecation is scheduled for the AngularJS Material 1.2 release. ' +
1781-
'To achieve the same results, use the panelContainer or panelEl ' +
1782-
'JQLite elements that are referenced in MdPanelRef.');
1783-
1784-
if (!this.panelContainer) {
1785-
throw new Error(
1786-
'mdPanel: Panel does not exist yet. Call open() or attach().');
1787-
}
1788-
1789-
if (!fromElement && this.panelContainer.hasClass(oldClass)) {
1790-
this.panelContainer.removeClass(oldClass);
1791-
} else if (fromElement && this.panelEl.hasClass(oldClass)) {
1792-
this.panelEl.removeClass(oldClass);
1793-
}
1794-
};
1795-
1796-
1797-
/**
1798-
* Toggle a class on the panel. DO NOT use this to hide/show the panel.
1799-
* @deprecated
1800-
* This method is in the process of being deprecated in favor of using the panel
1801-
* and container JQLite elements that are referenced in the MdPanelRef object.
1802-
* Full deprecation is scheduled for material 1.2.
1803-
*
1804-
* @param {string} toggleClass The class to toggle.
1805-
* @param {boolean} onElement Whether or not to toggle the class on the panel
1806-
* element instead of the container.
1807-
*/
1808-
MdPanelRef.prototype.toggleClass = function(toggleClass, onElement) {
1809-
this._$log.warn(
1810-
'mdPanel: The toggleClass method is in the process of being deprecated. ' +
1811-
'Full deprecation is scheduled for the AngularJS Material 1.2 release. ' +
1812-
'To achieve the same results, use the panelContainer or panelEl ' +
1813-
'JQLite elements that are referenced in MdPanelRef.');
1814-
1815-
if (!this.panelContainer) {
1816-
throw new Error(
1817-
'mdPanel: Panel does not exist yet. Call open() or attach().');
1818-
}
1819-
1820-
if (!onElement) {
1821-
this.panelContainer.toggleClass(toggleClass);
1822-
} else {
1823-
this.panelEl.toggleClass(toggleClass);
1824-
}
1825-
};
1826-
1827-
18281690
/**
18291691
* Compiles the panel, according to the passed in config and appends it to
18301692
* the DOM. Helps normalize differences in the compilation process between

0 commit comments

Comments
 (0)