Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(calendar): revert removal of workaround for virtual repeat issue #11939

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

md-calendar when used outside of md-datepicker doesn't scroll to the current month and stays on January 1880.

Issue Number:
Fixes #11919

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This is a regression fix for an issue with PR #11906 that has not yet been part of a release.

- #8585 turned out to not be a bug
- this restored code is not actually a workaround for a bug
  - but actually part of the implementation needed for `md-calendar`
- improve some types and JSDoc

Fixes #11919
@Splaktar Splaktar self-assigned this Jun 16, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 16, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone Jun 16, 2020
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug labels Jun 16, 2020
@Splaktar Splaktar requested a review from mmalerba June 16, 2020 01:27
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jun 16, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Jun 17, 2020
@Splaktar Splaktar merged commit 6f64da6 into master Jun 17, 2020
@Splaktar Splaktar deleted the calendar-fix-scroll branch June 17, 2020 04:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calendar: demo broken, showing 1880 dates, while model is correct
3 participants