This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(gesture): check if navigator is defined before accessing userAgent #11755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
PR #11729 in
1.1.19
moved the check fornavigator
outside of code that depends on gestures being enabled. Since it doesn't check the existence ofwindow.navigator
first, this could throw an error when built viaangular/material-tools
.Issue Number:
Fixes #11751
What is the new behavior?
Fixes a build error when using
angular/material-tools
by checking thatwindow.navigator
is defined before accessing it.Does this PR introduce a breaking change?
Other information
We don't have any tests that verify changes to
angular/material
don't breakangular/material-tools
. This was manually verified in #11751 (comment).