This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(gesture): tapping a submit button fires two submit events on mobile #11729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
added
type: bug
ui: mobile
browser: Safari
os: iOS
googlebot
added
the
cla: yes
Splaktar
added
pr: merge ready
this causes the dynamic tabs demo w/ pagination to often add two tabs for each 'Add Tab' button click on iOS and Android when click hijacking is enabled (default) - isKeyClick check did not work on iOS since clientX/Y are set - add an iOS-specific isKeyClick check - revert workaround from PR #10189 use recommended `new MouseEvent()` and `new CustomEvent()` - fallback to deprecated methods `initMouseEvent()` and `initCustomEvent()` Fixes #11725
Splaktar
force-pushed
the
gesture-fixDoubleSubmit
branch
from
75960f6 to
f6f4848
Compare
|
@andrewseguin rebased. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
1.1.4, tapping a submit button fires two submit events on mobile. This causes the dynamic tabs demo w/ pagination to often add two tabs for each 'Add Tab' button click on iOS and Android.Issue Number:
Fixes #11725
What is the new behavior?
when click hijacking is enabled (default)
webkitForceas there was no other way to differentiate the click events without recordingtouchstartand other events and then trying to look through recent history.use recommended
new MouseEvent()andnew CustomEvent()initMouseEvent()andinitCustomEvent()Does this PR introduce a breaking change?
Other information
Tests could not be added as we have not test infrastructure for Android and iOS.
Tested on
More info on creating and triggering events can be found on MDN.