Skip to content

fix(docs): make isFocusTrapEnabled internal, removing it from docs #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(docs): make isFocusTrapEnabled internal, removing it from docs #7298

merged 1 commit into from
Sep 29, 2017

Conversation

josephperrott
Copy link
Member

Fixes #7228

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 25, 2017
crisbeto
crisbeto approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add it as a breaking change on the off-chance that somebody was using it?

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 25, 2017
jelbourn
jelbourn approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott
Make isFocusTrapEnabled internal, removing it from docs.
db72d07 
BREAKING CHANGE: `isFocusTrapEnabled` is now properly marked internal.
@andrewseguin andrewseguin merged commit ce6cc0b into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
@josephperrott josephperrott deleted the sidenav branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What does isFocusTrapEnabled do on a sidenav? How is it used?
5 participants
@josephperrott @jelbourn @crisbeto @googlebot @andrewseguin