Skip to content

Make the inspector work with post-processing enabled #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Make the inspector work with post-processing enabled #5684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions examples/showcase/post-processing/bloom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ AFRAME.registerComponent('bloom', {
this.size = new THREE.Vector2();
this.scene = this.el.object3D;
this.renderer = this.el.renderer;
this.camera = this.el.camera;
this.originalRender = this.el.renderer.render;
this.bind();
},
Expand All @@ -56,8 +55,10 @@ AFRAME.registerComponent('bloom', {
this.composer = new EffectComposer(this.renderer, renderTarget);

// create render pass
var renderScene = new RenderPass(this.scene, this.camera);
this.composer.addPass(renderScene);
if (!this.renderPass) {
this.renderPass = new RenderPass(this.scene, this.el.camera);
}
this.composer.addPass(this.renderPass);

// create bloom pass
var strength = this.data.strength;
Expand Down Expand Up @@ -91,6 +92,9 @@ AFRAME.registerComponent('bloom', {
self.originalRender.apply(this, arguments);
} else {
isInsideComposerRender = true;
// always set the current active camera on the RenderPass so that the
// inspector controls are working properly with post-processing enabled
self.renderPass.camera = self.el.camera;
self.composer.render(self.el.sceneEl.delta / 1000);
isInsideComposerRender = false;
}
Expand Down