Skip to content

Make the inspector work with post-processing enabled #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

Make the inspector work with post-processing enabled #5684

merged 1 commit into from
Mar 5, 2025

Conversation

vincentfretin
Copy link
Contributor

Description:

Make the inspector work with post-processing enabled.

Changes proposed:

  • Set camera on the renderPass so it uses the correct camera when using the inspector, there is no performance impact doing that, we just set a variable
  • Also don't recreate the RenderPass instance when toggling the bloom effect

@dmarcos
Copy link
Member

dmarcos commented Mar 5, 2025

Thanks!

@dmarcos dmarcos merged commit fb67c01 into aframevr:master Mar 5, 2025
3 checks passed
@vincentfretin vincentfretin deleted the fix-inspector-with-bloom branch March 5, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentfretin @dmarcos