-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: Use inert in ariaHideOutside #8372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One bug found was that hovering a S2 SubmenuTrigger causes a focus ring to appear around the submenu that appears |
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know we found some things, but happy to get back in to work on more
@devongovett While you're deeper in the topic of ariaHideOutside, could you take a look at this issue? #8268 (comment) |
Build successful! 🎉 |
…71-revert-8317-use-inert # Conflicts: # packages/@react-aria/overlays/src/ariaHideOutside.ts
This reverts commit 34bc815.
Fixed issues from testing:
Investigated Firefox issue with focus not moving into Picker on mouse down. Turns out it is due to this 25 year old bug: https://bugzilla.mozilla.org/show_bug.cgi?id=53579 where calling |
Build successful! 🎉 |
## API Changes
@react-aria/overlays/@react-aria/overlays:ariaHideOutside ariaHideOutside {
targets: Array<Element>
- root: Element
+ options?: AriaHideOutsideOptions | Element
returnVal: undefined
} @react-spectrum/overlays/@react-spectrum/overlays:Overlay Overlay {
children: ReactNode
container?: Element
disableFocusManagement?: boolean
isKeyboardDismissDisabled?: boolean
isOpen?: boolean
nodeRef: MutableRefObject<HTMLElement | null>
onEnter?: () => void
onEntered?: () => void
onEntering?: () => void
onExit?: () => void
onExited?: () => void
onExiting?: () => void
+ shouldContainFocus?: boolean
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified the S2 submenu hover fix and the VO iOS dialog fix locally, the rest of the behavior seems to work well in my quick sweep. Approving for testing
Reverts #8371