chore: Revert "Use inert in ariaHideOutside" #8371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 431241e.
devongovett
changed the title
|
Build successful! 🎉 |
## API Changes
@react-aria/overlays/@react-aria/overlays:ariaHideOutside ariaHideOutside {
targets: Array<Element>
- options?: AriaHideOutsideOptions | Element
+ root: any
returnVal: undefined
}@react-spectrum/overlays/@react-spectrum/overlays:Overlay Overlay {
children: ReactNode
container?: Element
disableFocusManagement?: boolean
isKeyboardDismissDisabled?: boolean
isOpen?: boolean
nodeRef: MutableRefObject<HTMLElement | null>
onEnter?: () => void
onEntered?: () => void
onEntering?: () => void
onExit?: () => void
onExited?: () => void
onExiting?: () => void
- shouldContainFocus?: boolean
} |
LFDanLu
approved these changes
Jun 9, 2025
reidbarber
approved these changes
Jun 9, 2025
devongovett
added a commit
that referenced
this pull request
Jun 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
* Revert "Revert "chore: Use inert in ariaHideOutside (#8317)" (#8371)" This reverts commit 26f9102. * Fix focus ring appearing on S2 submenus * Fix firefox focusing Picker/Menu items when clicking with mouse * Fix dialog re-focusing with iOS VO * Revert "Fix firefox focusing Picker/Menu items when clicking with mouse" This reverts commit 34bc815. --------- Co-authored-by: Daniel Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8317
Will return after patch release.