Upgrade to node 24 #888

salmanmkc · 2025-07-31T14:45:33Z

Upgrading action to node 24 since new runner version.

Description:
Describe your changes.

Related issue:
Add link to the related issue.

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

Upgrading action to node 24 since new runner version.

djohnson20589-jpg · 2025-08-07T19:00:02Z

Upgrading action to node 24 since new runner version.

Description: Describe your changes.

Related issue: Add link to the related issue.

Check list:

Mark if documentation changes are required.

Mark if tests were added or updated to cover the changes.

Copilot

Pull Request Overview

This PR upgrades the GitHub Action from Node.js 20 to Node.js 24 to align with the newer runner version requirements.

Updates the action runtime environment from node20 to node24
Updates Node.js type definitions and engine requirements to version 24
Fixes TypeScript compilation issues that arose from stricter type checking in Node 24

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
action.yml	Updates the action runtime from `node20` to `node24`
package.json	Adds Node.js engine requirement and updates @types/node to v24
.github/workflows/*.yml	Updates CI workflows to use Node.js 24.x
tests/distributors/*.test.ts	Fixes TypeScript type issues with os.arch() mocking
.licenses/npm/*.dep.yml	Updates license information for dependency version changes

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-19T09:41:50Z

__tests__/distributors/temurin-installer.test.ts

-      jest.spyOn(os, 'arch').mockReturnValue(distroArch);
+      jest
+        .spyOn(os, 'arch')
+        .mockReturnValue(osArch as ReturnType<typeof os.arch>);


The mock is using osArch but should be using distroArch to match the test parameter. This inconsistency could cause the test to not properly validate the architecture mapping.

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0. Release notes *Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888) > > Make sure your runner is updated to this version or newer to use this release. v2.327.1 [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Dependency Upgrades > > * Upgrade Publish Immutable Action by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#798](https://redirect.github.com/actions/setup-java/pull/798) > * Upgrade eslint-plugin-jest from 27.9.0 to 28.11.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#730](https://redirect.github.com/actions/setup-java/pull/730) > * Upgrade undici from 5.28.5 to 5.29.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#833](https://redirect.github.com/actions/setup-java/pull/833) > * Upgrade form-data to bring in fix for critical vulnerability by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#887](https://redirect.github.com/actions/setup-java/pull/887) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#896](https://redirect.github.com/actions/setup-java/pull/896) > > ### Bug Fixes > > * Prevent default installation of JetBrains pre-releases by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-java#859](https://redirect.github.com/actions/setup-java/pull/859) > * Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failures by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848) > > New Contributors > ---------------- > > * [`@gowridurgad`](https://github.com/gowridurgad) made their first contribution in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848) > * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888) > > **Full Changelog**: <actions/setup-java@v4...v5.0.0> Commits * [`dded088`](actions/setup-java@dded088) Bump actions/checkout from 4 to 5 ([#896](https://redirect.github.com/actions/setup-java/issues/896)) * [`0913e9a`](actions/setup-java@0913e9a) Upgrade to node 24 ([#888](https://redirect.github.com/actions/setup-java/issues/888)) * [`e9343db`](actions/setup-java@e9343db) Bumps form-data ([#887](https://redirect.github.com/actions/setup-java/issues/887)) * [`ae2b61d`](actions/setup-java@ae2b61d) Bump undici from 5.28.5 to 5.29.0 ([#833](https://redirect.github.com/actions/setup-java/issues/833)) * [`c190c18`](actions/setup-java@c190c18) Bump eslint-plugin-jest from 27.9.0 to 29.0.1 ([#730](https://redirect.github.com/actions/setup-java/issues/730)) * [`67aec00`](actions/setup-java@67aec00) Fix: prevent default installation of JetBrains pre-releases ([#859](https://redirect.github.com/actions/setup-java/issues/859)) * [`ebb356c`](actions/setup-java@ebb356c) Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failu... * [`f4f1212`](actions/setup-java@f4f1212) Update publish-immutable-actions.yml ([#798](https://redirect.github.com/actions/setup-java/issues/798)) * See full diff in [compare view](actions/setup-java@c5195ef...dded088) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-java&package-manager=github\_actions&previous-version=4.7.1&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

salmanmkc added 2 commits July 31, 2025 15:45

Upgrade to node 24

dc9eba3

Upgrading action to node 24 since new runner version.

fix tests

bb39e34

salmanmkc added 4 commits August 8, 2025 07:02

Fix tests and licences

e987e88

format

ec5db35

format x2

9f65915

Upgrade Node.js version in workflow files to 24.x

4f5bea9

salmanmkc mentioned this pull request Aug 13, 2025

Support node22 in runs.using for JavaScript actions actions/runner#3600

Open

aparnajyothi-y marked this pull request as ready for review August 19, 2025 09:41

Copilot AI review requested due to automatic review settings August 19, 2025 09:41

aparnajyothi-y requested a review from a team as a code owner August 19, 2025 09:41

Copilot AI reviewed Aug 19, 2025

View reviewed changes

aparnajyothi-y and others added 3 commits August 19, 2025 16:06

check failure fix

f60809d

check failures fix

09fb092

Fix mock platform

6d73940

aparnajyothi-y approved these changes Aug 20, 2025

View reviewed changes

mahabaleshwars approved these changes Aug 20, 2025

View reviewed changes

HarithaVattikuti approved these changes Aug 20, 2025

View reviewed changes

HarithaVattikuti merged commit 0913e9a into actions:main Aug 20, 2025
364 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to node 24 #888

Upgrade to node 24 #888

Uh oh!

salmanmkc commented Jul 31, 2025

Uh oh!

djohnson20589-jpg commented Aug 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Uh oh!

Uh oh!

Upgrade to node 24 #888

Upgrade to node 24 #888

Uh oh!

Conversation

salmanmkc commented Jul 31, 2025

Uh oh!

djohnson20589-jpg commented Aug 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!