-
Notifications
You must be signed in to change notification settings - Fork 797
Fix: prevent default installation of JetBrains pre-releases #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: prevent default installation of JetBrains pre-releases #859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the JetBrains distributions handling to prevent the default installation of pre-release (EA) versions unless explicitly requested. Key changes include updating the raw version interface to include a prerelease flag and changing the build property type, and modifying the installer logic to filter versions based on the stability setting.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/distributions/jetbrains/models.ts | Added the prerelease flag and changed the build property from a number to a string. |
src/distributions/jetbrains/installer.ts | Adjusted version filtering logic to include the new prerelease field and updated build parsing. |
Comments suppressed due to low confidence (3)
src/distributions/jetbrains/models.ts:12
- Changing the build property type from number to string may affect consumers of this API. Please verify that all dependent logic now correctly treats build as a string.
build: string;
src/distributions/jetbrains/installer.ts:164
- [nitpick] With the build property now being a string, ensure that all logic relying on the build value (e.g., version comparisons) correctly handles string values instead of numbers.
const build = vsplit[1];
src/distributions/jetbrains/installer.ts:126
- [nitpick] The filtering logic based on the stable flag now directly uses the prerelease field. Ensure this behavior is well-tested so that only the intended versions are selected based on the stability preference.
this.stable ? !version.prerelease : version.prerelease
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
Love it😁 |
Love it |
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0. Release notes *Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888) > > Make sure your runner is updated to this version or newer to use this release. v2.327.1 [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Dependency Upgrades > > * Upgrade Publish Immutable Action by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#798](https://redirect.github.com/actions/setup-java/pull/798) > * Upgrade eslint-plugin-jest from 27.9.0 to 28.11.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#730](https://redirect.github.com/actions/setup-java/pull/730) > * Upgrade undici from 5.28.5 to 5.29.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#833](https://redirect.github.com/actions/setup-java/pull/833) > * Upgrade form-data to bring in fix for critical vulnerability by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#887](https://redirect.github.com/actions/setup-java/pull/887) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#896](https://redirect.github.com/actions/setup-java/pull/896) > > ### Bug Fixes > > * Prevent default installation of JetBrains pre-releases by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-java#859](https://redirect.github.com/actions/setup-java/pull/859) > * Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failures by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848) > > New Contributors > ---------------- > > * [`@gowridurgad`](https://github.com/gowridurgad) made their first contribution in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848) > * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888) > > **Full Changelog**: <actions/setup-java@v4...v5.0.0> Commits * [`dded088`](actions/setup-java@dded088) Bump actions/checkout from 4 to 5 ([#896](https://redirect.github.com/actions/setup-java/issues/896)) * [`0913e9a`](actions/setup-java@0913e9a) Upgrade to node 24 ([#888](https://redirect.github.com/actions/setup-java/issues/888)) * [`e9343db`](actions/setup-java@e9343db) Bumps form-data ([#887](https://redirect.github.com/actions/setup-java/issues/887)) * [`ae2b61d`](actions/setup-java@ae2b61d) Bump undici from 5.28.5 to 5.29.0 ([#833](https://redirect.github.com/actions/setup-java/issues/833)) * [`c190c18`](actions/setup-java@c190c18) Bump eslint-plugin-jest from 27.9.0 to 29.0.1 ([#730](https://redirect.github.com/actions/setup-java/issues/730)) * [`67aec00`](actions/setup-java@67aec00) Fix: prevent default installation of JetBrains pre-releases ([#859](https://redirect.github.com/actions/setup-java/issues/859)) * [`ebb356c`](actions/setup-java@ebb356c) Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failu... * [`f4f1212`](actions/setup-java@f4f1212) Update publish-immutable-actions.yml ([#798](https://redirect.github.com/actions/setup-java/issues/798)) * See full diff in [compare view](actions/setup-java@c5195ef...dded088) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Description:
This update ensures that JetBrains Runtime pre-release (EA) versions are excluded by default unless explicitly requested. This prevents unintended installation of EA builds when specifying a standard version like
21
.Related issue:
#829
Check list: