build: update rocksdb to 0.24 - #10922
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the rocksdb dependency from 0.22 to 0.24, which brings the bundled librocksdb-sys from 0.16.0+8.10.0 to 0.17.3+10.4.2 (i.e. the vendored RocksDB C++ library jumps from 8.10.0 to 10.4.2). It addresses issue #10904 (Zebra was pinned to an old RocksDB) and is expected to help with #10024. The change is confined to dependency metadata; there are no source-code changes, and existing rocksdb::* API usage in zebra-state appears compatible.
Changes:
- Bump
rocksdbworkspace dependency to0.24inCargo.toml. - Regenerate
Cargo.lock:librocksdb-sys→0.17.3+10.4.2,rocksdb→0.24.0, deduplicatebindgento0.72.1, collapserustc-hashto a single2.1.2, and drop now-unusedbindgen 0.69.5,itertools 0.12.1,lazycell, andrustc-hash 1.1.0.
Risk scan / notes (for human reviewer):
- State/consensus layer risk: This bumps the database engine backing
zebra-stateacross a major RocksDB version (8.10 → 10.4). On-disk format compatibility, default table/format behavior, and migration considerations should be validated on a real synced database, not just a fresh one. - Supply-chain / CI completeness (blocking): The
cargo vet checkexemptions insupply-chain/config.tomlstill pin the oldrocksdb 0.22.0andlibrocksdb-sys 0.16.0+8.10.0, anddeny.tomlstill carries a stalebindgen =0.69.5skip-tree entry. These need updating (see inline comment). - MSRV: Confirm
rocksdb 0.24/librocksdb-sys 0.17.3still build under the workspace MSRV (1.85.1) used byzebra-state.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Cargo.toml |
Bumps the workspace rocksdb dependency from 0.22 to 0.24. |
Cargo.lock |
Regenerated lockfile: updated rocksdb/librocksdb-sys versions and pruned transitively-removed crates (bindgen 0.69.5, itertools 0.12.1, lazycell, rustc-hash 1.1.0). |
conradoplg
force-pushed
the
update-rocksdb-0.24
branch
from
July 8, 2026 14:17
0ef9567 to
7af3a53
Compare
conradoplg
force-pushed
the
update-rocksdb-0.24
branch
from
July 8, 2026 15:19
7af3a53 to
429e7fc
Compare
gustavovalverde
previously approved these changes
Jul 10, 2026
Member
|
Admin merging as I had to rebase and last pusher can't approve |
7 tasks
6 tasks
ebfull
added a commit
to zakura-core/zakura
that referenced
this pull request
Jul 30, 2026
* build: update rocksdb to 0.24 and bump zakura-state to 6.0.0 Ports ZcashFoundation/zebra#10922. RocksDB 8.10.0 (bundled by rocksdb 0.22) is missing #include <cstdint> in several public headers, which fails to compile under GCC 15/16; RocksDB 10.4.2 (rocksdb 0.24) has the upstream fixes, removing the CXXFLAGS="-include cstdint" workaround from the Arch Linux build instructions. librocksdb-sys 0.17 always runs bindgen, so libclang is now a build dependency even when linking a system RocksDB via ROCKSDB_LIB_DIR; the Ubuntu CI setup action installs it explicitly. rocksdb types appear in zakura-state's public API, so the dependency major bump is a semver-major change: zakura-state 5.0.1 -> 6.0.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(changelog): add fragment for rocksdb 0.24 update Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #10904
Closes #10024
See issue for rationale and analysis
Solution
Tests
Specifications & References
Follow-up Work
AI Disclosure
PR Checklist
type(scope): description