build: update rocksdb to 0.24 (#10922)

Co-authored-by: Gustavo Valverde <g.valverde02@gmail.com>

Author: conradoplg

.github/actions/setup-zebra-build/action.yml

@@ -1,12 +1,15 @@
 name: 'Setup Zebra Build Environment'
-description: 'Install protoc and RocksDB as system libraries'
+description: 'Install libclang, protoc, and RocksDB as system libraries'
 runs:
   using: 'composite'
   steps:
-    - name: Install protoc and librocksdb-dev on Ubuntu
+    - name: Install libclang, protoc, and librocksdb-dev on Ubuntu
       if: runner.os == 'Linux'
       shell: bash
       run: |
         sudo apt-get -qq update
-        sudo apt-get -qq install -y --no-install-recommends protobuf-compiler librocksdb-dev
+        # libclang is needed at build time: librocksdb-sys always runs bindgen
+        # (via clang-sys) to generate FFI bindings, even when linking the system
+        # RocksDB via ROCKSDB_LIB_DIR.
+        sudo apt-get -qq install -y --no-install-recommends clang libclang-dev protobuf-compiler librocksdb-dev
         echo "ROCKSDB_LIB_DIR=/usr/lib/" >> $GITHUB_ENV

CHANGELOG.md

@@ -9,6 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 
 ### Changed
 
+- Updated `rocksdb` to 0.24. The bundled `librocksdb-sys` now always runs
+  `bindgen` to generate its FFI bindings, so **`libclang` is required at build
+  time** (in addition to `protoc` and a C++ compiler) even when linking a system
+  RocksDB via `ROCKSDB_LIB_DIR`. Install `libclang-dev` (Debian/Ubuntu),
+  `clang` (Arch), or the equivalent for your platform.
 - Bumped the workspace (libraries) MSRV from 1.85.1 to 1.88. The `zebrad` binary
   MSRV is unchanged at 1.91. `home` is no longer pinned to 0.5.11, since 0.5.12
   builds on the new MSRV.

Cargo.lock

@@ -372,26 +372,6 @@ dependencies = [
  "serde",
 ]
 
-[[package]]
-name = "bindgen"
-version = "0.69.5"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "271383c67ccabffb7381723dea0672a673f292304fcb45c01cc648c7a8d58088"
-dependencies = [
- "bitflags",
- "cexpr",
- "clang-sys",
- "itertools 0.12.1",
- "lazy_static",
- "lazycell",
- "proc-macro2",
- "quote",
- "regex",
- "rustc-hash 1.1.0",
- "shlex",
- "syn 2.0.117",
-]
-
 [[package]]
 name = "bindgen"
 version = "0.72.1"
@@ -405,7 +385,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "regex",
- "rustc-hash 2.1.2",
+ "rustc-hash",
  "shlex",
  "syn 2.0.117",
 ]
@@ -2627,15 +2607,6 @@ dependencies = [
  "either",
 ]
 
-[[package]]
-name = "itertools"
-version = "0.12.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ba291022dbbd398a455acf126c1e341954079855bc60dfdda641363bd6922569"
-dependencies = [
- "either",
-]
-
 [[package]]
 name = "itertools"
 version = "0.13.0"
@@ -2769,7 +2740,7 @@ dependencies = [
  "jsonrpsee-types",
  "parking_lot",
  "rand 0.8.6",
- "rustc-hash 2.1.2",
+ "rustc-hash",
  "serde",
  "serde_json",
  "thiserror 1.0.69",
@@ -2876,12 +2847,6 @@ dependencies = [
  "spin",
 ]
 
-[[package]]
-name = "lazycell"
-version = "1.3.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "830d08ce1d1d941e6b30645f1a0eb5643013d835ce3779a5fc208261dbe10f55"
-
 [[package]]
 name = "leb128fmt"
 version = "0.1.0"
@@ -2933,14 +2898,13 @@ dependencies = [
 
 [[package]]
 name = "librocksdb-sys"
-version = "0.16.0+8.10.0"
+version = "0.17.3+10.4.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ce3d60bc059831dc1c83903fb45c103f75db65c5a7bf22272764d9cc683e348c"
+checksum = "cef2a00ee60fe526157c9023edab23943fae1ce2ab6f4abb2a807c1746835de9"
 dependencies = [
- "bindgen 0.69.5",
+ "bindgen",
  "bzip2-sys",
  "cc",
- "glob",
  "libc",
  "libz-sys",
  "lz4-sys",
@@ -2964,7 +2928,7 @@ version = "0.1.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "3f8ce05b56f3cbc65ec7d0908adb308ed91281e022f61c8c3a0c9388b5380b17"
 dependencies = [
- "bindgen 0.72.1",
+ "bindgen",
  "cc",
  "thiserror 2.0.18",
  "tracing",
@@ -4168,7 +4132,7 @@ dependencies = [
  "pin-project-lite",
  "quinn-proto",
  "quinn-udp",
- "rustc-hash 2.1.2",
+ "rustc-hash",
  "rustls",
  "socket2",
  "thiserror 2.0.18",
@@ -4189,7 +4153,7 @@ dependencies = [
  "lru-slab",
  "rand 0.9.4",
  "ring",
- "rustc-hash 2.1.2",
+ "rustc-hash",
  "rustls",
  "rustls-pki-types",
  "slab",
@@ -4628,9 +4592,9 @@ dependencies = [
 
 [[package]]
 name = "rocksdb"
-version = "0.22.0"
+version = "0.24.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6bd13e55d6d7b8cd0ea569161127567cd587676c99f4472f779a0279aa60a7a7"
+checksum = "ddb7af00d2b17dbd07d82c0063e25411959748ff03e8d4f96134c2ff41fce34f"
 dependencies = [
  "libc",
  "librocksdb-sys",
@@ -4672,12 +4636,6 @@ version = "0.1.27"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "b50b8869d9fc858ce7266cce0194bd74df58b9d0e3f6df3a9fc8eb470d95c09d"
 
-[[package]]
-name = "rustc-hash"
-version = "1.1.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "08d43f7aa6b08d49f382cde6a7982047c3426db949b1424bc4b7ec9ae12c6ce2"
-
 [[package]]
 name = "rustc-hash"
 version = "2.1.2"

Cargo.toml

@@ -123,7 +123,7 @@ regex = "1.11"
 reqwest = { version = "0.12", default-features = false }
 ripemd = "0.1"
 rlimit = "0.10"
-rocksdb = { version = "0.22", default-features = false }
+rocksdb = { version = "0.24", default-features = false }
 secp256k1 = "0.29"
 semver = "1.0.26"
 sentry = { version = "0.47", default-features = false }

book/src/user/install.md

@@ -88,7 +88,16 @@ If you are having trouble with:
 - **clang:** Install both `libclang` and `clang` - they are usually different
   packages.
 - **libclang:** Check out the [clang-sys
-  documentation](https://github.com/KyleMayes/clang-sys#dependencies).
+  documentation](https://github.com/KyleMayes/clang-sys#dependencies). If the
+  build fails with `couldn't find any valid shared libraries matching:
+  ['libclang.so', 'libclang-*.so']`, libclang is not installed or is not on the
+  search path: install the `libclang-dev` package (Debian/Ubuntu) or set
+  `LIBCLANG_PATH` to the directory that contains `libclang.so`.
+- **shared libraries:** If the build fails with `error while loading shared
+  libraries: libclang-*.so.*: cannot open shared object file`, you have the
+  libclang **dev** files but are missing the matching **runtime** library.
+  Install the runtime package (`libclang1-<version>` on Debian/Ubuntu) or run
+  `sudo ldconfig`.
 - **g++ or MSVC++:** Try using `clang` or `Xcode` instead.
 - **rustc:** Use the latest stable `rustc` and `cargo` versions.
 - **dependencies**: Use `cargo install` without `--locked` to build with the

deny.toml

@@ -110,9 +110,6 @@ skip-tree = [
     # wait for abscissa_core to update toml
     { name = "toml", version = "=0.5.11" },
 
-    # wait for librocksdb-sys to update bindgen
-    { name = "bindgen", version = "=0.69.5" },
-
     # wait for halo2_gadgets and primitive-types to update uint
     { name = "uint", version = "=0.9.5" },
 

supply-chain/config.toml

@@ -885,10 +885,6 @@ criteria = "safe-to-deploy"
 version = "0.2.19"
 criteria = "safe-to-deploy"
 
-[[exemptions.lazycell]]
-version = "1.3.0"
-criteria = "safe-to-deploy"
-
 [[exemptions.libc]]
 version = "0.2.186"
 criteria = "safe-to-deploy"
@@ -910,7 +906,7 @@ version = "0.1.16"
 criteria = "safe-to-deploy"
 
 [[exemptions.librocksdb-sys]]
-version = "0.16.0+8.10.0"
+version = "0.17.3+10.4.2"
 criteria = "safe-to-deploy"
 
 [[exemptions.libz-sys]]
@@ -1017,10 +1013,6 @@ criteria = "safe-to-deploy"
 version = "0.3.2"
 criteria = "safe-to-deploy"
 
-[[exemptions.objc2-core-graphics]]
-version = "0.3.2"
-criteria = "safe-to-deploy"
-
 [[exemptions.objc2-core-image]]
 version = "0.3.2"
 criteria = "safe-to-deploy"
@@ -1392,7 +1384,7 @@ version = "0.10.1"
 criteria = "safe-to-deploy"
 
 [[exemptions.rocksdb]]
-version = "0.22.0"
+version = "0.24.0"
 criteria = "safe-to-deploy"
 
 [[exemptions.ron]]