Skip to content

P2 690 expose shortlinks #16822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2021
Merged

P2 690 expose shortlinks #16822

merged 5 commits into from
Mar 25, 2021

Conversation

andizer
Copy link
Contributor

@andizer andizer commented Mar 24, 2021

Context

  • We want to show a warning message with a link that navigates the user to additional info about required en recommended blocks.

Summary

This PR can be summarized in the following changelog entry:

  • Exposes two shortlinks by using localize script

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

P2-690

@andizer andizer added innovation Innovative issue. Relating to performance, memory or data-flow. changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Mar 24, 2021
@hansjovis hansjovis self-requested a review March 25, 2021 10:00
@hansjovis hansjovis self-assigned this Mar 25, 2021
Copy link
Contributor

@hansjovis hansjovis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 👍

@hansjovis
Copy link
Contributor

Acceptance test: 🚫

Link is not blue, so not according to design.

For sake of expediency I am going to fix this myself.

@hansjovis
Copy link
Contributor

Made link blue:
Screenshot 2021-03-25 at 11 28 04

@hansjovis hansjovis merged commit 4349e8b into trunk Mar 25, 2021
@hansjovis hansjovis deleted the P2-690-expose-shortlinks branch March 25, 2021 10:46
@enricobattocchi enricobattocchi added this to the 16.2 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants