Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Shows a link in the warning #1117

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Shows a link in the warning #1117

merged 3 commits into from
Mar 25, 2021

Conversation

andizer
Copy link
Contributor

@andizer andizer commented Mar 24, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/schema-blocks] Fixes a bug where the link to additional information in the warning was missing.

Test instructions

This PR can be tested by following these steps:

  • Test this against P2 690 expose shortlinks wordpress-seo#16822 and the trunk of Yoast SEO Premium.
  • Add the jobs block to a post
  • Remove the title or description. You will see an error with a link. Navigate to that link and see that you get navigated to the yoast.com help page. The page itself probably doesn't exist yet. But the url should be like this https://yoast.com/help/required-recommended-optional-fields.... with some additional UTM tags. Note the &utm_term=required%20block
  • Now remove the requirements block for example
  • You will get an warning about the removal of a recommended block. This block also should have a link that navigates to https://yoast.com/help/required-recommended-optional-fields.... and see that there is a utm_term=recommended%20block

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@andizer andizer added UI change PRs that result in a change in the UI innovation changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog labels Mar 24, 2021
@hansjovis hansjovis self-requested a review March 25, 2021 10:00
@hansjovis hansjovis self-assigned this Mar 25, 2021
@hansjovis
Copy link
Contributor

hansjovis commented Mar 25, 2021

Acceptance test: 🚫

Link is not blue, so not according to the design.

For sake of expediency I fixed it myself.

@hansjovis hansjovis merged commit f0edfb4 into develop Mar 25, 2021
@hansjovis hansjovis deleted the P2-690-show-link-in-warning branch March 25, 2021 10:46
@increddibelly increddibelly added this to the 16.2 milestone Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog innovation UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants