Skip to content

Resolving NodeJS Travis CI Issues #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

vincentkoc
Copy link
Contributor

Relating to bug in Travis CI causing build failures (#29)

  • Allow failure when code coverage is not working
  • De-couple code coverage from packages.json
  • Add logical Node JS ordering to versions in Travis CI
  • Add Node JS version 9, 10, 11, and nightly builds (nodejs)

Build changes including new PR seems to pass https://travis-ci.org/koconder/Parser-JavaScript/builds/482370762

Disconnecting Code Coverage from Tests
Adding logical versions and failure ability on nightly builds
@mariotsi
Copy link
Member

Thank you @koconder for this CR.

@mariotsi mariotsi merged commit 2886542 into WhichBrowser:master Jan 22, 2019
vincentkoc referenced this pull request in vincentkoc/Parser-JavaScript Jan 22, 2019
Resolving NodeJS Travis CI Issues (#30)
@vincentkoc vincentkoc deleted the dev-travisci branch January 22, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants