Removing Unicode EN+Space for Space #29
Conversation
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
|
Hey, on this PR. Test pasted by Travis CI. However it seems to be causing an issue on the codecoverage report for some odd reason. See screenshot, please review CI log or re-run/fix CI issue before dismissing this PR.
|
Disconnecting Code Coverage from Tests
Adding logical versions and failure ability on nightly builds
Updates to Travis CI
Bumps [eslint](https://github.com/eslint/eslint) from 4.19.1 to 5.12.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v4.19.1...v5.12.1) Signed-off-by: dependabot[bot] <[email protected]>
|
Please see PR #30 for resolving the Travis CI issues |
…12.1 Bump eslint from 4.19.1 to 5.12.1
Bumps [request](https://github.com/request/request) from 2.87.0 to 2.88.0. - [Release notes](https://github.com/request/request/releases) - [Changelog](https://github.com/request/request/blob/master/CHANGELOG.md) - [Commits](request/request@v2.87.0...v2.88.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov](https://github.com/codecov/codecov-node) from 2.3.1 to 3.1.0. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](codecov/codecov-node@v2.3.1...v3.1.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [prettier](https://github.com/prettier/prettier) from 1.13.7 to 1.16.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@1.13.7...1.16.0) Signed-off-by: dependabot[bot] <[email protected]>
…-1.16.0 Bump prettier from 1.13.7 to 1.16.0
….1.0 Bump codecov from 2.3.1 to 3.1.0
….88.0 Bump request from 2.87.0 to 2.88.0
|
PR #30 merged. Can you rebase your PR on top of it so we can test it via Travis? Thanks |
Resolving NodeJS Travis CI Issues (#30)
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
|
@mariotsi i have rebased the PR and tests for the unicode fix are now passing |
|
@koconder just realised that I cannot merge it because the data files are automatically generated by downloading and adapting the PHP version. Thanks! |
|
@mariotsi just FYI i have made a PR to the PHP Build as well, see WhichBrowser/Parser-PHP#106 Let me know how best to proceed, if we need to close this PR if the PHP data-files is fixed. Or if its worth me updating the "builder" to strip unicode. |
|
I've to check which is the source of data of the PHP version. If I remember well even those are automatically generate. I will check it this evening and let you know |
|
@mariotsi any updates for me to rectify my PR's? |
|
Yes, sorry I've checked but I didn't replied to you. @NielsLeenheer seems busy at the moment, so in order to don't block this PR I would like to remove the change from the data files, keep it the test files and update the script in order to strip the characters in a way that won't break when PHP changes are merged. Let me know if you feel comfortable in doing so otherwise I'll do it and you can rebase on top of it 💪 |
|
@mariotsii might need a hand with the changes you have asked, my node.js skills are not the best and I dont know how the functions for building so might be best handled by someone more versed on the repo. Or we just hold tight for the PR merge on the PHP version. |
|
@koconder No worries. This weekend I'll add the code for stripping the character so can rebase on top of it. I'm not so keen to wait for the PHP version because often @NielsLeenheer is busy and cannot merge PRs/comment on issue. Additionally the change I'm gonna make will not break when he will merge 🤙 |
|
This PR has been merged to the branch Strip-EN+Space-from-models-and-profiles and is now part of #33 |
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106