feat(alerting): Add RESULT_CONDITIONS in custom alert to have more information #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
aalmenar
changed the title
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
3 times, most recently
from
e9223fd to
e7597a1
Compare
Contributor
Author
|
Rebased patch after: fix(alerting): Escape custom result errors |
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
2 times, most recently
from
869fdf9 to
2ddec80
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
3 times, most recently
from
1a1426e to
08eb98e
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
1e3abec to
a1a6a1b
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
2 times, most recently
from
7d9acd2 to
2dffcf0
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
2dffcf0 to
da56af1
Compare
|
It would be nice to have this on Gatus! For us it is useful to integrate it with our alert system. @TwiN Could you take a look at it? |
TwiN
requested changes
Aug 1, 2025
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
3 times, most recently
from
d12c941 to
7d13b47
Compare
Contributor
Author
|
@TwiN any comments after the changes ? |
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
7d13b47 to
b96dbb1
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
b96dbb1 to
3225f58
Compare
Owner
|
I'm working on a very large change that touches nearly half of the files, that's why I haven't looked at this yet FYI |
Contributor
Author
Since 5.24.0 is released now, can we revisit this? |
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
2 times, most recently
from
de3e119 to
6cd3393
Compare
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
6cd3393 to
67b591b
Compare
Contributor
Author
Don’t forget this !! 😉 |
TwiN
approved these changes
Oct 4, 2025
Owner
|
@aalmenar Thank you for the reminder! |
Owner
|
Can you test your change? I see you checked that you tested the change, but I'm not seeing any tests 🧐 |
Contributor
Author
Sure, i will add some tests to the changes. But i have it on at least 4 instances working correctly. I will add the tests no matter what. |
Owner
|
Thank you! The main reason I want tests is in part to make sure it works, but also to make sure future changes don't break the new feature. I'll have another look once you pushed the tests, thank you for your patience! |
…formation on an alert while using custom alerting module Add testing of new feature
aalmenar
force-pushed
the
add_conditions_to_custom_alerting
branch
from
488e5da to
60e75f8
Compare
Contributor
Author
|
Hi @TwiN, i have added a test for this feature, and squashed the commits into 1. Hope its ok for finally merging it.
|
TwiN
approved these changes
Oct 6, 2025
Owner
|
Thank you for the contribution! |
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Oct 7, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.25.2` -> `v5.26.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.26.0`](https://github.com/TwiN/gatus/releases/tag/v5.26.0) [Compare Source](TwiN/gatus@v5.25.2...v5.26.0) #### What's Changed - feat(alerting): Add support for n8n alerts by [@​TwiN](https://github.com/TwiN) in [#​1309](TwiN/gatus#1309) - feat(client): Support body placeholder for SSH endpoints by [@​yansh97](https://github.com/yansh97) in [#​1286](TwiN/gatus#1286) - feat(alerting): Add RESULT\_CONDITIONS in custom alert to have more information by [@​aalmenar](https://github.com/aalmenar) in [#​1086](TwiN/gatus#1086) - fix(alerting): Implement deduplication key generation for incidentio alerts by [@​NerdySoftPaw](https://github.com/NerdySoftPaw) in [#​1296](TwiN/gatus#1296) - fix(ui): Swap oldest/newest result time for SuiteCard.vue by [@​TwiN](https://github.com/TwiN) in [#​1308](TwiN/gatus#1308) - fix(alerting): Format link from Telegram alert description when sending message by [@​andriyor](https://github.com/andriyor) in [#​1200](TwiN/gatus#1200) - chore(deps): Update aws-sdk-go to aws-sdk-go-v2 by [@​TwiN](https://github.com/TwiN) in [#​1305](TwiN/gatus#1305) #### New Contributors - [@​NerdySoftPaw](https://github.com/NerdySoftPaw) made their first contribution in [#​1296](TwiN/gatus#1296) - [@​yansh97](https://github.com/yansh97) made their first contribution in [#​1286](TwiN/gatus#1286) - [@​andriyor](https://github.com/andriyor) made their first contribution in [#​1200](TwiN/gatus#1200) **Full Changelog**: <TwiN/gatus@v5.25.2...v5.26.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjEzNS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1689 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This helps solving issue: #1085
Since this adds a new placeholder shouldn't interfere with the current behaviour gatus has.
Checklist
README.md, if applicable.