🌐 Translated new keys for Turkish#25978
Conversation
WalkthroughThis pull request updates Turkish language translations across three JSON localization files within the Ghost CMS platform. It fills previously empty translation strings with complete Turkish text for authentication messages, email notifications, billing information, and portal elements. The changes also standardize terminology by consistently using "bağlantı" (connection/link) instead of "link" throughout the Turkish translations to improve linguistic consistency and adherence to Turkish language conventions. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cathysarisky
left a comment
There was a problem hiding this comment.
📋 My AI helper 🤖 left you a few comments. I always believe the human over the AI, so feel free to disregard them after you take a careful look!
Leave me a comment when you're satisfied with everything, please. :)
🤖 AI: Overall, the translations appear to be of high quality, with a clear, friendly tone that fits Ghost’s style and good consistency in terminology across files (e.g. "giriş bağlantısı", "e-posta", "abonelik"). Variables like {siteTitle}, {otc}, {submittedEmailOrInbox}, and others are preserved correctly everywhere I checked, and there is no sign of defacement or inappropriate content.
The main patterns I noticed are very small stylistic points: occasional mixing of informal imperative ("tıkla", "onayla") with more formal/plural forms ("tıklayın", "giriniz") and a couple of places where English UI commands could potentially sound slightly more natural in Turkish with a verb ending ("kullan"/"kullanın"). There is also one likely semantic nuance around "Billing info & receipts" where "fatura başlığı" might be narrower than the original "billing info". Spelling and grammar are generally very solid; only tiny things like "hoşgeldin" vs "hoş geldin" might merit a quick review for consistency if you agree.
Overall, the work is careful and consistent, and my comments are mostly minor suggestions rather than corrections. Çok teşekkürler, elinize sağlık. Teşekkürler!
Drafted with my new i18n tooling - feedback welcome
|
There's a conflict in portal.json on line 26: It was "Billing info & receipts" when I first opened the PR. Then @cathysarisky merged upstream main to the PR, changing this line to: "Billing info" Now after I updated the PR accordingly, the very same line reverted back to its previous state on the main branch. Shall I proceed with "Billing info" or "Billing info & receipts"? |
|
You're not wrong here - that string has changed twice in the last two weeks. Here's the current version in English - please match that key. https://github.com/TryGhost/Ghost/blob/main/ghost/i18n/locales/en/portal.json |
|
Ok, this I updated. Not committed yet, I am waiting for your opinion on the matter I commented above, the variable {submittedEmailOrInbox} |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
🌐 Some missing keys for Turkish language were added. Some of them also were updated to use more "Turkish" words instead of direct loans.
Note
Low Risk
Low risk: changes are limited to Turkish locale JSON strings and only affect displayed copy (with some previously-empty keys now translated).
Overview
Adds missing Turkish translations across
comments.json,ghost.json, andportal.json, notably for sign-in/magic-link flows and various Portal UI messages.Also refines existing Turkish copy to more natural wording (e.g., replacing direct “link” loanwords with “bağlantı”, adjusting a few labels like
Name).Written by Cursor Bugbot for commit 55103d9. This will update automatically on new commits. Configure here.