Added getMetadataMap to Array #157
Conversation
gsvic
force-pushed
the
vg/feature/ArrayMetadataGet
branch
from
2f9c4cb to
ce660cc
Compare
| * @return The metadata | ||
| * @throws TileDBError | ||
| */ | ||
| public Map<String, Object> getMetadataMap() throws TileDBError { |
There was a problem hiding this comment.
Hmm, so we need to know the metadata type for the each key ahead of time?
There was a problem hiding this comment.
The idea behind that is that we can get the class of each object returned using .getClass. We could also provide the type as well, by returning something like Pair<NativeArray, Datatype> or Pair<Object, Datatype> but this would make the API more complex, without providing something more than .getClass() provides.
So we need either know the metadata type ahead of time or consider do some type-check before reading each value.
There was a problem hiding this comment.
OH, Java! Forgetting about it always; LGTM than! I will remove this method from my PR than and can leave only a simple putMetadata overload :D
There was a problem hiding this comment.
Sounds good! You can take a look here on how to use the .getClass() method: https://docs.oracle.com/javase/tutorial/reflect/class/classNew.html
You can also take a look on how getClass() is used in that unit test: https://github.com/TileDB-Inc/TileDB-Java/pull/157/files#diff-d38ae1adae50d20e357b8edd3c64de26R554
There was a problem hiding this comment.
@gsvic thanks ;) I'm just looking at everything through the prism of a typed API (got used to it after years in Scala).
Added the
getMetadataMapmethod, which returns a HashMap containing the Array metadata in a key-value manner.