Add putMetadata overload #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the follow up @pomadchin! I recently opened a similar PR which returns a It seems that your PR contains some changes that mine does not, so we can somehow merge these two. + @Shelnutt2 |
pomadchin
force-pushed
the
feature/metadata-overload
branch
from
d2acf76 to
71f4e3c
Compare
|
@gsvic that is nice! you can close this PR and grab the |
pomadchin
force-pushed
the
feature/metadata-overload
branch
2 times, most recently
from
970fc44 to
28592dd
Compare
pomadchin
force-pushed
the
feature/metadata-overload
branch
from
28592dd to
d423d41
Compare
Shelnutt2
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra putMetadata overload which is more user friendly.
It is the follow up PR for the #155