Skip to content

SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change#240

Merged
antoine-vinot-sonarsource merged 1 commit into
masterfrom
avi/fix-default-skip-signature-verification
Apr 29, 2026
Merged

SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change#240
antoine-vinot-sonarsource merged 1 commit into
masterfrom
avi/fix-default-skip-signature-verification

Conversation

@antoine-vinot-sonarsource

@antoine-vinot-sonarsource antoine-vinot-sonarsource commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Tested without dirmngr.

With the signature verification

Screenshot 2026-04-29 100012

Without the signature verification

image

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Apr 29, 2026

Copy link
Copy Markdown

SQSCANGHA-140

@sonar-review-alpha

sonar-review-alpha Bot commented Apr 29, 2026

Copy link
Copy Markdown

Summary

Changes the default behavior of the skipSignatureVerification input in the SonarQube scan action from false (verify signatures by default) to true (skip verification by default).

This is a temporary measure to prevent workflows from failing while a dirmngr dependency issue is being resolved. Users who have the dependency available can explicitly set skipSignatureVerification: false to enable signature verification. The description has been updated to clarify this temporary state and the path forward.

What reviewers should know

What changed: Only action.yml — the input default and its description.

Why this matters: This changes the action's security posture by default (signatures won't be verified unless explicitly enabled). The change is intentional and temporary, with a dependency issue being the blocker for the ideal state.

For reviewers: Verify that:

  • The description accurately reflects the temporary nature and the dirmngr dependency context
  • This is the intended behavior (accepting reduced security by default to avoid workflow breakage)
  • The description clearly guides users on how to restore signature verification once the dependency is resolved

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonarqubecloud

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple one-line change with a clear rationale, but there are two things worth addressing before merge.

🗣️ Give feedback

Comment thread action.yml
Comment thread action.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoine-vinot-sonarsource antoine-vinot-sonarsource merged commit c7ee0f9 into master Apr 29, 2026
77 checks passed
@antoine-vinot-sonarsource antoine-vinot-sonarsource deleted the avi/fix-default-skip-signature-verification branch April 29, 2026 08:13
luketainton pushed a commit to luketainton/repos_pypilot that referenced this pull request May 1, 2026
…441)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | major | `v7.2` → `v8.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v8`](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

### [`v8.0`](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

### [`v8.0.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v7.2.1...v8.0.0)

#### What's Changed

##### Breaking change

- SQSCANGHA-145 Set skipSignatureVerification default value to false by [@&#8203;antoine-vinot-sonarsource](https://github.com/antoine-vinot-sonarsource) in [#&#8203;241](SonarSource/sonarqube-scan-action#241)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v7...v8.0.0>

### [`v7.2.1`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v7.2.1)

[Compare Source](SonarSource/sonarqube-scan-action@v7.2...v7.2.1)

#### What's Changed

- SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change by [@&#8203;gmmcal](https://github.com/gmmcal) in [#&#8203;240](SonarSource/sonarqube-scan-action#240)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v7...v7.2.1>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/441
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton pushed a commit to luketainton/repos_epage-go that referenced this pull request May 1, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | major | `v7.2` → `v8.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v8`](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

### [`v8.0`](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

### [`v8.0.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v7.2.1...v8.0.0)

#### What's Changed

##### Breaking change

- SQSCANGHA-145 Set skipSignatureVerification default value to false by [@&#8203;antoine-vinot-sonarsource](https://github.com/antoine-vinot-sonarsource) in [#&#8203;241](SonarSource/sonarqube-scan-action#241)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v7...v8.0.0>

### [`v7.2.1`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v7.2.1)

[Compare Source](SonarSource/sonarqube-scan-action@v7.2...v7.2.1)

#### What's Changed

- SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change by [@&#8203;gmmcal](https://github.com/gmmcal) in [#&#8203;240](SonarSource/sonarqube-scan-action#240)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v7...v7.2.1>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/epage-go/pulls/9
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton pushed a commit to luketainton/repos_roboluke that referenced this pull request May 11, 2026
…446)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | major | `v7.2` → `v8.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v8.0.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

#### What's Changed

##### Breaking change

- SQSCANGHA-145 Set skipSignatureVerification default value to false by [@&#8203;antoine-vinot-sonarsource](https://github.com/antoine-vinot-sonarsource) in [#&#8203;241](SonarSource/sonarqube-scan-action#241)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v7...v8.0.0>

### [`v8.0`](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.0.0...v8.0.0)

### [`v8`](SonarSource/sonarqube-scan-action@v7.2.1...v8.0.0)

[Compare Source](SonarSource/sonarqube-scan-action@v7.2.1...v8.0.0)

### [`v7.2.1`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v7.2.1)

[Compare Source](SonarSource/sonarqube-scan-action@v7.2...v7.2.1)

#### What's Changed

- SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change by [@&#8203;gmmcal](https://github.com/gmmcal) in [#&#8203;240](SonarSource/sonarqube-scan-action#240)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v7...v7.2.1>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE2Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/446
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants