SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change#239
SQSCANGHA-140 Set skipSignatureVerification default value to true to avoid breaking change#239gmmcal wants to merge 1 commit into
Conversation
SummaryThis PR flips the default value of What reviewers should knowWhat to review:
Context for reviewers:
Verification approach:
|
…avoid breaking change Address SonarSource#235 (comment)
d4650bf to
a224a62
Compare
|
There was a problem hiding this comment.
The action.yml description fix is a clear improvement — the "not recommended for security" framing is gone and replaced with an accurate explanation of the temporary default. However, the PR missed a directly related piece: the runtime warning in src/main/install-sonar-scanner.js:61 still reads "⚠ Skipping GPG signature verification (not recommended)". With the default now true, this warning fires on every standard run for every user who hasn't explicitly set the input. Users will see a "not recommended" alarm for the behavior this PR explicitly designates as the safe, expected default — which directly undermines the goal of a smooth user experience. The warning text needs to be updated to match the intent (e.g., "⚠ GPG signature verification is disabled. Set skipSignatureVerification: false to enable it once dirmngr is available on your runner."). Update dist/index.js accordingly after changing the source.



Address #235 (comment)
On #235, a new feature was introduce to check OpenPGP signature and improve security standards. Even though this is a great feature, it breaks the action execution when
dirmngris not present on runner. Shortly after feature was merged, remarks came into PR to point that out. Full error log is belowThis PR aims to change default value of
skipSignatureVerificationto true, until a proper structural solution is in place within the action flow or Sonar team decides to mark this feature as a breaking change, turning default value tofalseon av8future release.