VorbisComments: Parse TRACKNUMBER
with respect to implicit_conversion
#542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #540.
This PR make VorbisComments parse
TRACKNUMBER
with respect toParseOption::implicit_conversions
Note
Let me know if there is something more that should be done.
I'm not sure if I need to update the
Accessor
forVorbisComments
. The goal is to ensure thattrack
andtrack_total
can still be called and returnu32
values, even when the format is<current>/<total>
.What do you think?