VorbisComments: Remove track number test files

Author: Serial-ATA

CHANGELOG.md

@@ -22,7 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **ID3v2**: Support parsing UTF-16 `COMM`/`USLT` frames with a single BOM ([issue](https://github.com/Serial-ATA/lofty-rs/issues/532)) ([PR](https://github.com/Serial-ATA/lofty-rs/pull/535))
   - Some encoders will only write a BOM to the frame's description, rather than to every string in the frame.
     This was previously only supported in `SYLT` frames, and has been extended to `COMM` and `USLT`.
-- **Vorbis Comments**: Parse `TRACKNUMBER` with respect to `ParseOptions::implicit_conversions` ([issue](https://github.com/Serial-ATA/lofty-rs/issues/540))
+- **Vorbis Comments**: Parse `TRACKNUMBER` with respect to `ParseOptions::implicit_conversions` ([issue](https://github.com/Serial-ATA/lofty-rs/issues/540)) ([PR](https://github.com/Serial-ATA/lofty-rs/issues/542))
 
 ### Removed
 

lofty/src/ogg/tag.rs

@@ -923,4 +923,58 @@ mod tests {
 		assert_eq!(tag.pictures().len(), 0); // Artist, no picture
 		assert!(tag.artist().is_some());
 	}
+
+	// case TRACKNUMBER=01/05 disable implicit_conversions
+	#[test_log::test]
+	fn issue_540_disable_implicit_conversions() {
+		let mut comments = VorbisComments::new();
+		comments.insert(String::from("TRACKNUMBER"), String::from("01/05"));
+
+		let mut comments_bytes = Vec::new();
+		comments
+			.dump_to(&mut comments_bytes, WriteOptions::default())
+			.unwrap();
+
+		let mut reader = Cursor::new(&comments_bytes);
+		let tag = crate::ogg::read::read_comments(
+			&mut reader,
+			comments_bytes.len() as u64,
+			ParseOptions::new()
+				.parsing_mode(ParsingMode::Strict)
+				.implicit_conversions(false)
+				.read_cover_art(false),
+		)
+		.unwrap();
+
+		assert_eq!(tag.track(), None);
+		assert_eq!(tag.track_total(), None);
+		assert_eq!(tag.get("TRACKNUMBER"), Some("01/05"));
+	}
+
+	// case track number and total with leading 0
+	#[test_log::test]
+	fn opus_issue_540_leading_0() {
+		let mut comments = VorbisComments::new();
+		comments.insert(String::from("TRACKNUMBER"), String::from("01"));
+		comments.insert(String::from("TRACKTOTAL"), String::from("05"));
+
+		let mut comments_bytes = Vec::new();
+		comments
+			.dump_to(&mut comments_bytes, WriteOptions::default())
+			.unwrap();
+
+		let mut reader = Cursor::new(&comments_bytes);
+		let tag = crate::ogg::read::read_comments(
+			&mut reader,
+			comments_bytes.len() as u64,
+			ParseOptions::new()
+				.parsing_mode(ParsingMode::Strict)
+				.implicit_conversions(false)
+				.read_cover_art(false),
+		)
+		.unwrap();
+
+		assert_eq!(tag.get("TRACKNUMBER"), Some("01"));
+		assert_eq!(tag.get("TRACKTOTAL"), Some("05"));
+	}
 }

lofty/tests/files/assets/issue_540.opus

@@ -181,41 +181,6 @@ fn opus_issue_499() {
 	assert_eq!(comments.track_total(), Some(22));
 }
 
-// case TRACKNUMBER=01/05 disable implicit_conversions
-#[test_log::test]
-fn opus_issue_540_disable_implicit_conversions() {
-	use lofty::ogg::OpusFile;
-
-	let file = std::fs::read("tests/files/assets/issue_540.opus").unwrap();
-	let opus_file = OpusFile::read_from(
-		&mut std::io::Cursor::new(file),
-		ParseOptions::new().implicit_conversions(false),
-	)
-	.unwrap();
-
-	let comments = opus_file.vorbis_comments();
-	assert_eq!(comments.track(), None);
-	assert_eq!(comments.track_total(), None);
-	assert_eq!(comments.get("TRACKNUMBER"), Some("01/05"));
-}
-
-// case track number and total with leading 0
-#[test_log::test]
-fn opus_issue_540_leading_0() {
-	use lofty::ogg::OpusFile;
-
-	let file = std::fs::read("tests/files/assets/issue_540_leading_0.opus").unwrap();
-	let opus_file = OpusFile::read_from(
-		&mut std::io::Cursor::new(file),
-		ParseOptions::new().implicit_conversions(false),
-	)
-	.unwrap();
-
-	let comments = opus_file.vorbis_comments();
-	assert_eq!(comments.get("TRACKNUMBER"), Some("01"));
-	assert_eq!(comments.get("TRACKTOTAL"), Some("05"));
-}
-
 // case TRACKNUMBER=a5 (vinyl format)
 #[test_log::test]
 fn opus_issue_499_vinyl_track_number() {