fix(core,platform): schematics, deps, migrations, assets & styles #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

platon-rov merged 3 commits into main from pr/fix/schematics-fixes-and-theming-support

Nov 7, 2022

Contributor

platon-rov commented Jul 29, 2022 •

edited

Loading

Original PR #8465 <= Please check comments there also

Related Issue(s)

Closes #8350
Closes #8457
Refers to #8258

Description

Library deps were made peerDeps to fix various issues with multiple deps instances.
Core schematics updated to setup Theming out of the box.
Core schematics styles and assets adding fixed to have all the files only on the library (our) side.
Migrations created to remove old styles and assets.

TDB, Not done

Removing the old deprecated Themes.

Please check whether the PR fulfills the following requirements

PR Quality

Breaking Changes Wiki

platon-rov added enhancement core labels

platon-rov requested a review from a team

July 29, 2022 15:22

platon-rov self-assigned this

netlify bot commented Jul 29, 2022 •

edited

Loading

✅ Deploy Preview for fundamental-ngx ready!

Name	Link
🔨 Latest commit	`dbe2303`
🔍 Latest deploy log	https://app.netlify.com/sites/fundamental-ngx/deploys/6368eed2b7cbbf000865b81f
😎 Deploy Preview	https://deploy-preview-8479--fundamental-ngx.netlify.app/docs/fn/input/examples/input-form-group-example.component
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions bot commented Jul 29, 2022 •

edited

Loading

Visit the preview URL for this PR (updated for commit 1f03534):

https://fundamental-ngx-gh--pr8479-pr-fix-schematics-fi-prwessxz.web.app

_{(expires Sat, 03 Sep 2022 07:57:14 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

g-cheishvili approved these changes

View reviewed changes

Contributor

g-cheishvili left a comment

Only grammatical issues, nothing more

libs/core/schematics/migrations/migration-0.36/index.ts Outdated Show resolved Hide resolved

libs/core/schematics/migrations/migration-0.36/index.ts Outdated Show resolved Hide resolved

libs/core/schematics/utils/file-utils.ts Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

g-cheishvili suggested changes

View reviewed changes

Contributor

g-cheishvili left a comment

See above

github-actions bot commented Aug 1, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions bot added the stale label

InnaAtanasova removed the stale label

platon-rov mentioned this pull request

feat(styles): sap font stylesheets SAP/fundamental-styles#3764

Merged

Contributor Author

platon-rov commented Aug 2, 2022

[BLOCKED] by SAP/fundamental-styles#3764

Reason #8465 (comment)

platon-rov added the blocked label

platon-rov force-pushed the pr/fix/schematics-fixes-and-theming-support branch from 72639f3 to 78e3309 Compare

August 2, 2022 13:02

platon-rov mentioned this pull request

[draft] feat(core,platform): skeleton & skeleton state for components #8258

Closed

github-actions bot commented Aug 5, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions bot added the stale label

platon-rov removed the stale label

github-actions bot commented Aug 8, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions bot added the stale label

platon-rov removed the stale label

platon-rov marked this pull request as draft

August 9, 2022 12:12

github-actions bot commented Aug 12, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions bot added the stale label

InnaAtanasova removed the stale label

github-actions bot commented Aug 15, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions bot added the stale label

platon-rov removed the stale label

InnaAtanasova added this to the Sprint 94 - Montevideo milestone

InnaAtanasova added this to the Sprint 96 - Panama City milestone

InnaAtanasova modified the milestones: Sprint 96 - Panama City, Sprint 97 - Santa Cruz

platon-rov requested review from g-cheishvili and removed request for g-cheishvili

September 19, 2022 10:38

platon-rov force-pushed the pr/fix/schematics-fixes-and-theming-support branch from 1f03534 to 05578ce Compare

September 27, 2022 09:58

InnaAtanasova modified the milestones: Sprint 97 - Santa Cruz, Sprint 98 - Managua

platon-rov requested a review from a team

October 10, 2022 12:28

InnaAtanasova modified the milestones: Sprint 98 - Managua, Sprint 99 - Guatemala

InnaAtanasova reviewed

View reviewed changes

libs/platform/src/lib/package.json Show resolved Hide resolved

InnaAtanasova reviewed

View reviewed changes

libs/core/src/lib/package.json Show resolved Hide resolved

platon-rov force-pushed the pr/fix/schematics-fixes-and-theming-support branch from 05578ce to 64e36dd Compare

October 31, 2022 08:38

github-actions bot commented Oct 31, 2022 •

edited

Loading

Visit the preview URL for this PR (updated for commit dbe2303):

https://fundamental-ngx-gh--pr8479-pr-fix-schematics-fi-dy0fsce3.web.app

_{(expires Thu, 10 Nov 2022 11:52:12 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff}


          feat(core): assets & styles, fonts, schematics, migrations

8dc91fa

BREAKING CHANGE:
* after update with `ng update` you have to run `ng add @fundamental-ngx/core` once again

platon-rov force-pushed the pr/fix/schematics-fixes-and-theming-support branch from 64e36dd to 8dc91fa Compare

October 31, 2022 12:23

platon-rov requested review from InnaAtanasova and g-cheishvili and removed request for g-cheishvili

October 31, 2022 12:24

InnaAtanasova modified the milestones: Sprint 99 - Guatemala, Sprint 100 - San Salvador

g-cheishvili reviewed

View reviewed changes

libs/core/schematics/migrations.json Show resolved Hide resolved

InnaAtanasova approved these changes

View reviewed changes


          Merge branch 'main' into pr/fix/schematics-fixes-and-theming-support

3d8b8ba

g-cheishvili approved these changes

View reviewed changes


          Merge branch 'main' into pr/fix/schematics-fixes-and-theming-support

dbe2303

platon-rov merged commit 6e9e86d into main

platon-rov deleted the pr/fix/schematics-fixes-and-theming-support branch

November 7, 2022 13:42

platon-rov mentioned this pull request

fix(core,platform): schematics and deps #8952

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels