fix(core,platform): schematics, deps, migrations, assets & styles #8465

platon-rov · 2022-07-28T12:36:39Z

Related Issue(s)

Closes #8350
Closes #8457
Refers to #8258

Description

Library deps were made peerDeps to fix various issues with multiple deps instances.
Core schematics updated to setup Theming out of the box.
Core schematics styles and assets adding fixed to have all the files only on the library (our) side.
Migrations created to remove old styles and assets.

TDB, Not done

Removing the old deprecated Themes.

Please check whether the PR fulfills the following requirements

PR Quality

Breaking Changes Wiki

…cies fixed

BREAKING CHANGES: * previously created styles and assets are outdated now. use `ng update` to fix them automatically. * after update run `ng add @fundamental-ngx/core` once again to automatically setup things in the new way.

netlify · 2022-07-28T12:45:59Z

✅ Deploy Preview for fundamental-ngx ready!

Name	Link
🔨 Latest commit	`72639f3`
🔍 Latest deploy log	https://app.netlify.com/sites/fundamental-ngx/deploys/62e28573df4ad3000872d830
😎 Deploy Preview	https://deploy-preview-8465--fundamental-ngx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2022-07-28T12:46:14Z

Visit the preview URL for this PR (updated for commit 72639f3):

https://fundamental-ngx-gh--pr8465-pr-fix-schematics-me-l3ntmedx.web.app

_{(expires Sun, 31 Jul 2022 12:56:22 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

N1XUS

Awesome job!

N1XUS · 2022-07-29T07:47:26Z

libs/core/schematics/migrations/migration-0.36/index.ts

+
+function noticeAddSchematics(): Rule {
+    return (_: Tree, context: SchematicContext) => {
+        context.logger.info(`ℹ️ Now you have run ng-add schematics once again to setup things in the right way.`);


Can't we just run another migration here which will do what's needed?

As I mentioned in the comment in the code below we can but we cannot pass options there. All the prompts will be asked again but $defaults won't be resolved properly.

N1XUS · 2022-07-29T07:49:13Z

libs/core/schematics/ng-add/index.ts

-                    overwrite: true
-                });
-            }
+        if (


Can't we just move it to fundamental-ngx dependencies tree so it would automatically install needed version even if user simply updates the version manually in package.json of his/hers project?

If you mean make styles & base-theming deps of the ngx/core - no we can't.

In the code below we set some assets & styles using relative paths

./node_modules/@sap-theming/theming-base-content/content/Base/baseLib/

In case we will have them as deps they may be placed under the specified path or under the following path

./node_modules/@fundamental-ngx/core/node_modules/@sap-theming/theming-base-content/content/Base/baseLib/

and it may change in future, see more about it in ticket #8350

N1XUS · 2022-07-29T07:50:56Z

libs/core/schematics/ng-add/index.ts

-    };
-}
+            if (options.fonts) {
+                additionalStyles.push('./node_modules/@fundamental-ngx/core/assets/fundamental-ngx-core-fonts.scss');


If user's project uses less/css instead of scss? Maybe provide a simple css file which would 100% work?

SAP/fundamental-styles#3764

libs/core/schematics/ng-add/index.ts

N1XUS · 2022-07-29T08:21:02Z

libs/core/src/lib/assets/fonts/sap_fiori_3_fonts.css

@@ -0,0 +1,6 @@
+@font-face {


I think more correct way would be to move all css-related code to fundamental-styles theming. What do you think?

If you mean fonts - agree, we could do this.

But common css libs/core/src/lib/assets/fundamental-ngx-core.scss probably should be kept in ngx to have ability to add any code that might be not present in styles.

SAP/fundamental-styles#3764

…yles (#8465)" This reverts commit 1dc00d1.

…yles (#8465)" (#8475) This reverts commit 1dc00d1.

feat(core): fund-ngx/core root stylesheet, font stylesheets, dependen…

d4c9923

…cies fixed

platon-rov added platform labels Jul 28, 2022

platon-rov requested a review from a team July 28, 2022 12:36

platon-rov self-assigned this Jul 28, 2022

platon-rov force-pushed the pr/fix/schematics-mega-update branch from 2ab35e9 to 37d69eb Compare July 28, 2022 12:37

platon-rov mentioned this pull request Jul 28, 2022

[draft] feat(core,platform): skeleton & skeleton state for components #8258

Closed

fix(core): schematics

cd05149

BREAKING CHANGES: * previously created styles and assets are outdated now. use `ng update` to fix them automatically. * after update run `ng add @fundamental-ngx/core` once again to automatically setup things in the new way.

platon-rov added 2 commits July 28, 2022 14:47

feat(core): schematic migrations

9bc081a

fix(platform): deps

72639f3

platon-rov force-pushed the pr/fix/schematics-mega-update branch from 37d69eb to 72639f3 Compare July 28, 2022 12:47

droshev added this to the Sprint 93 - Manila milestone Jul 28, 2022

SAP deleted a comment from netlify bot Jul 28, 2022

N1XUS reviewed Jul 29, 2022

View reviewed changes

droshev merged commit 1dc00d1 into main Jul 29, 2022

droshev deleted the pr/fix/schematics-mega-update branch July 29, 2022 09:45

platon-rov added a commit that referenced this pull request Jul 29, 2022

Revert "fix(core,platform): schematics, deps, migrations, assets & st…

b451cbb

…yles (#8465)" This reverts commit 1dc00d1.

platon-rov added a commit that referenced this pull request Jul 29, 2022

fix(core,platform): revert "schematics, deps, migrations, assets & st…

62c0fbe

…yles (#8465)" This reverts commit 1dc00d1.

droshev pushed a commit that referenced this pull request Jul 29, 2022

fix(core,platform): revert "schematics, deps, migrations, assets & st…

ab27f69

…yles (#8465)" (#8475) This reverts commit 1dc00d1.

This was referenced Jul 29, 2022

fix(core,platform): schematics, deps, migrations, assets & styles #8479

Merged

feat(styles): sap font stylesheets SAP/fundamental-styles#3764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core,platform): schematics, deps, migrations, assets & styles #8465

fix(core,platform): schematics, deps, migrations, assets & styles #8465

Uh oh!

platon-rov commented Jul 28, 2022 •

edited

Loading

Uh oh!

netlify bot commented Jul 28, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jul 28, 2022 •

edited

Loading

Uh oh!

N1XUS left a comment

Uh oh!

N1XUS Jul 29, 2022

Uh oh!

platon-rov Jul 29, 2022 •

edited

Loading

Uh oh!

N1XUS Jul 29, 2022

Uh oh!

platon-rov Jul 29, 2022 •

edited

Loading

Uh oh!

N1XUS Jul 29, 2022

Uh oh!

platon-rov Aug 2, 2022

Uh oh!

Uh oh!

Uh oh!

N1XUS Jul 29, 2022

Uh oh!

platon-rov Jul 29, 2022

Uh oh!

platon-rov Aug 2, 2022

Uh oh!

Uh oh!

fix(core,platform): schematics, deps, migrations, assets & styles #8465

fix(core,platform): schematics, deps, migrations, assets & styles #8465

Uh oh!

Conversation

platon-rov commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue(s)

Description

Please check whether the PR fulfills the following requirements

PR Quality

Uh oh!

netlify bot commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fundamental-ngx ready!

Uh oh!

github-actions bot commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

N1XUS left a comment

Choose a reason for hiding this comment

Uh oh!

N1XUS Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

platon-rov Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

N1XUS Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

platon-rov Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

N1XUS Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

platon-rov Aug 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

N1XUS Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

platon-rov Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

platon-rov Aug 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

platon-rov commented Jul 28, 2022 •

edited

Loading

netlify bot commented Jul 28, 2022 •

edited

Loading

github-actions bot commented Jul 28, 2022 •

edited

Loading

platon-rov Jul 29, 2022 •

edited

Loading

platon-rov Jul 29, 2022 •

edited

Loading