Redisgraph cross validation #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treme importance to the overall benchmark
[add] clarify interactive properties file
(partially tracking changes on `dev` - will cause a trivial merge conflict)
Add foreign keys to PostgreSQL schema
Fix interactive tests
Interactive complex read query No. 13 possibly entered into infinite loop because of the bi-directional knows relationships. This caused the query to never complete in case of no path between person1 and person2, wgen person1 (the starting point) belongs to a component of more than one vertices.
Fix possible infinite loop in IC-13 query by recording the path.
This reverts commit 535f235.
…cification This is a more elegant approach than spelling it out after each parameter
Test SF1 in CI
Use ANALYZE instead of VACUUM FULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the
redisgraph.unstablebranch into sync with the upstream and tries to standardize the RedisGraph driver to the Neo4j example.The intention is to generate validation parameters and use them in the validation job for RedisGraph, providing cross-database correctness validation. As such, the Neo4j load scripts, driver, and queries have been modified to match the RedisGraph schema (which does not support things like datetimes).
Currently, this approach succeeds for 4 short queries, 7 updates, and 2 complex queries.
While the new
load-in-one-stepscript provisions a RedisGraph server from the Dockeredgeimage, these results actually rely on the current head of RedisGraph'smulti-label-nodebranch.