Skip to content

[add] clarify interactive properties file #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

filipecosta90
Copy link
Contributor

  • adds as comments to the interactive sample property files where to get the ldbc.snb.interactive.update_interleave value.
  • points towards the necessity of also updating the frequency of read queries based on SF

@szarnyasg
Copy link
Member

@filipecosta90 thanks for opening this PR! One question: the proposed frequency numbers seem to target SF100, is that correct? I think we'd better put SF1 values in the example property files (especially given that the properties files for some implementations, e.g. Postgres, actually encode the data set in the file). WDYT?

@filipecosta90
Copy link
Contributor Author

@filipecosta90 thanks for opening this PR! One question: the proposed frequency numbers seem to target SF100, is that correct? I think we'd better put SF1 values in the example property files (especially given that the properties files for some implementations, e.g. Postgres, actually encode the data set in the file). WDYT?

Totally agree. Changing frequency values to match SF1

@szarnyasg
Copy link
Member

Looks good, thanks!

@szarnyasg szarnyasg merged commit b64ab7d into ldbc:master Feb 27, 2020
@szarnyasg
Copy link
Member

One thing though... where did the update interleave 4477 come from?

For me, SF1 shows 113040.

$ cat params.ini 
ldbc.snb.datagen.generator.scaleFactor:snb.interactive.1

ldbc.snb.datagen.serializer.dynamicActivitySerializer:ldbc.snb.datagen.serializer.snb.csv.dynamicserializer.activity.CsvBasicDynamicActivitySerializer
ldbc.snb.datagen.serializer.dynamicPersonSerializer:ldbc.snb.datagen.serializer.snb.csv.dynamicserializer.person.CsvBasicDynamicPersonSerializer
ldbc.snb.datagen.serializer.staticSerializer:ldbc.snb.datagen.serializer.snb.csv.staticserializer.CsvBasicStaticSerializer

# To generate RFC 3339-compliant timestamps (https://tools.ietf.org/html/rfc3339), uncomment the following line:
#ldbc.snb.datagen.util.formatter.StringDateFormatter.dateTimeFormat:yyyy-MM-dd'T'HH:mm:ss.SSS+00:00
$ cat social_network/updateStream.properties 
ldbc.snb.interactive.gct_delta_duration:10000
ldbc.snb.interactive.min_write_event_start_time:1347528980076
ldbc.snb.interactive.max_write_event_start_time:1570999509040
ldbc.snb.interactive.update_interleave:113040
ldbc.snb.interactive.num_events:1976901

@filipecosta90
Copy link
Contributor Author

One thing though... where did the update interleave 4477 come from?

For me, SF1 shows 113040.

$ cat params.ini 
ldbc.snb.datagen.generator.scaleFactor:snb.interactive.1

ldbc.snb.datagen.serializer.dynamicActivitySerializer:ldbc.snb.datagen.serializer.snb.csv.dynamicserializer.activity.CsvBasicDynamicActivitySerializer
ldbc.snb.datagen.serializer.dynamicPersonSerializer:ldbc.snb.datagen.serializer.snb.csv.dynamicserializer.person.CsvBasicDynamicPersonSerializer
ldbc.snb.datagen.serializer.staticSerializer:ldbc.snb.datagen.serializer.snb.csv.staticserializer.CsvBasicStaticSerializer

# To generate RFC 3339-compliant timestamps (https://tools.ietf.org/html/rfc3339), uncomment the following line:
#ldbc.snb.datagen.util.formatter.StringDateFormatter.dateTimeFormat:yyyy-MM-dd'T'HH:mm:ss.SSS+00:00
$ cat social_network/updateStream.properties 
ldbc.snb.interactive.gct_delta_duration:10000
ldbc.snb.interactive.min_write_event_start_time:1347528980076
ldbc.snb.interactive.max_write_event_start_time:1570999509040
ldbc.snb.interactive.update_interleave:113040
ldbc.snb.interactive.num_events:1976901

for me it shows 4477 for SF1. Should it be related to our different ldbc.snb.interactive.max_write_event_start_time:1363757151388?

/neo4j-data-dir$ cat sf1/social_network/updateStream.properties 
ldbc.snb.interactive.gct_delta_duration:10000
ldbc.snb.interactive.min_write_event_start_time:1347528962967
ldbc.snb.interactive.max_write_event_start_time:1363757151388
ldbc.snb.interactive.update_interleave:4477
ldbc.snb.interactive.num_events:3623993

@szarnyasg
Copy link
Member

@filipecosta90 thanks! It seems some of our changes in the lifespans branch of Datagen made this diverge. We'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants