-
Notifications
You must be signed in to change notification settings - Fork 17
Mortar Transfer Function #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Rohit-Kakodkar
merged 6 commits into
PrincetonUniversity:devel
from
int-ptr-ptr:dg2d-mortartrans
Sep 22, 2025
Merged
Mortar Transfer Function #1227
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8d05535
define mortar transfer population functions
int-ptr-ptr 31224cd
Merge branch 'dg2d-mortar_reparam' into dg2d-mortartrans
int-ptr-ptr 33fee8f
populate functions + add test
int-ptr-ptr 595d55c
moved assembly dependent .cpp to .tpp (templates EdgeType)
int-ptr-ptr 86f53b1
fixed not setting default failstate = false
int-ptr-ptr dc8b6a7
review changes
int-ptr-ptr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 0 additions & 49 deletions
49
.../specfem/assembly/nonconforming_interfaces/dim2/impl/compute_intersection_in_assembly.cpp
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -8,6 +8,39 @@ | |||||
|
||||||
namespace specfem::assembly::nonconforming_interfaces_impl { | ||||||
|
||||||
/** | ||||||
* @brief A helper function that retrieves the element global coordinates and | ||||||
* edge orientation of a given adjacency in the adjacency graph. | ||||||
* | ||||||
* @param mesh - the assembly::mesh object | ||||||
* @param edge - the adjacency graph edge of the intersection. | ||||||
* mesh.graph()[edge] should reference the edge we want to | ||||||
* construct the intersection between. | ||||||
* @return std::tuple< | ||||||
* Kokkos::View< | ||||||
* specfem::point::global_coordinates<specfem::dimension::type::dim2> *, | ||||||
* Kokkos::HostSpace>, | ||||||
* Kokkos::View< | ||||||
* specfem::point::global_coordinates<specfem::dimension::type::dim2> *, | ||||||
* Kokkos::HostSpace>, | ||||||
* specfem::mesh_entity::type, specfem::mesh_entity::type> - in order: the | ||||||
* cooordinates of the source element, the coordinates of the target element, | ||||||
* the orientation on the source element in the intersection, and the | ||||||
* orientation on the target element in the intersection. | ||||||
*/ | ||||||
template <typename EdgeType> | ||||||
std::tuple< | ||||||
Kokkos::View< | ||||||
specfem::point::global_coordinates<specfem::dimension::type::dim2> *, | ||||||
Kokkos::HostSpace>, | ||||||
Kokkos::View< | ||||||
specfem::point::global_coordinates<specfem::dimension::type::dim2> *, | ||||||
Kokkos::HostSpace>, | ||||||
specfem::mesh_entity::type, specfem::mesh_entity::type> | ||||||
_expand_edge_index( | ||||||
|
_expand_edge_index( | |
expand_edge_index( |
All functions within the impl module are helper right?
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the 2 functions are doing the same thing. Can you call one from the other? I'd like to avoid duplicate code.