Mortar Transfer Function #1227
Merged
Mortar Transfer Function #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int-ptr-ptr
added
the
new physics
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Closed
4 tasks
|
Ok to test |
Rohit-Kakodkar
requested changes
Sep 19, 2025
| return intersections; | ||
| } | ||
|
|
||
| void specfem::assembly::nonconforming_interfaces_impl::set_transfer_functions( |
There was a problem hiding this comment.
Seems like the 2 functions are doing the same thing. Can you call one from the other? I'd like to avoid duplicate code.
| specfem::point::global_coordinates<specfem::dimension::type::dim2> *, | ||
| Kokkos::HostSpace>, | ||
| specfem::mesh_entity::type, specfem::mesh_entity::type> | ||
| _expand_edge_index( |
There was a problem hiding this comment.
Suggested change
| _expand_edge_index( | |
| expand_edge_index( |
All functions within the impl module are helper right?
Rohit-Kakodkar
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Takes reparameterization in #1186 and computes transfer functions from the edge to the mortar.
Current implemented test handles only the same cases as #1186 -- additional tests + minor test refactoring should occur with #1226.
Issue Number
Closes #1174.
Checklist
Please make sure to check developer documentation on specfem docs.