Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

closes #19771

PR #18957 added a log filter to suppress noisy SQLite "database is locked" errors from the uvicorn.error logger. However, when using flow.serve() with SQLite, background tasks like mark_deployments_ready run through docket and log errors through the docket.worker logger, which was not covered by the original fix.

This PR extends the existing SQLite lock log filter to also filter the docket.worker logger, silencing the harmless but alarming error messages that users see during onboarding.

Changes

  • Add docket.worker logger to the SQLite lock log filter installation
  • Add test coverage for the docket.worker logger case

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Human Review Checklist

  • Verify docket.worker is the correct logger name for docket task execution errors
  • Consider if there are other loggers that might emit similar SQLite lock errors

Link to Devin run: https://app.devin.ai/sessions/20e5e008a49b4757b66ba98ff91c9900
Requested by: Nate Nowack ([email protected]) (@zzstoatzz)

The existing fix in PR #18957 only filtered SQLite lock errors from the
uvicorn.error logger. However, when using flow.serve() with SQLite,
background tasks like mark_deployments_ready run through docket and log
errors through the docket.worker logger, which was not covered.

This change extends the SQLite lock log filter to also filter the
docket.worker logger, silencing the noisy but harmless 'database is locked'
errors that users see during onboarding.

Closes #19771

Co-Authored-By: Nate Nowack <[email protected]>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the bug Something isn't working label Dec 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 14, 2025

CodSpeed Performance Report

Merging #19772 will not alter performance

Comparing devin/1765685181-silence-docket-sqlite-lock-errors (4f7f6c4) with main (e0efe42)

Summary

✅ 2 untouched

@zzstoatzz zzstoatzz marked this pull request as ready for review December 14, 2025 04:16
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zzstoatzz zzstoatzz merged commit 96ab33f into main Dec 14, 2025
60 checks passed
@zzstoatzz zzstoatzz deleted the devin/1765685181-silence-docket-sqlite-lock-errors branch December 14, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When trying Getting Started example in documentation: sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is locked

2 participants