Silence retryable SQLite lock errors from docket.worker logger

The existing fix in PR #18957 only filtered SQLite lock errors from the
uvicorn.error logger. However, when using flow.serve() with SQLite,
background tasks like mark_deployments_ready run through docket and log
errors through the docket.worker logger, which was not covered.

This change extends the SQLite lock log filter to also filter the
docket.worker logger, silencing the noisy but harmless 'database is locked'
errors that users see during onboarding.

Closes #19771

Co-Authored-By: Nate Nowack <[email protected]>

Author: devin-ai-integration[bot]

src/prefect/server/api/server.py

@@ -156,6 +156,7 @@ def _install_sqlite_locked_log_filter() -> None:
 
     filter_ = _SQLiteLockedOperationalErrorFilter()
     logging.getLogger("uvicorn.error").addFilter(filter_)
+    logging.getLogger("docket.worker").addFilter(filter_)
     _SQLITE_LOCKED_LOG_FILTER = filter_
 
 

tests/server/api/test_server.py

@@ -112,13 +112,13 @@ async def raise_other_error():
         assert response.status_code == 500
 
 
-def _log_record_for_sqlite_error(orig_exc):
+def _log_record_for_sqlite_error(orig_exc, logger_name: str = "uvicorn.error"):
     try:
         raise sa.exc.OperationalError("statement", {"params": 1}, orig_exc, None)
     except sa.exc.OperationalError:
         exc_info = sys.exc_info()
     return logging.LogRecord(
-        name="uvicorn.error",
+        name=logger_name,
         level=logging.ERROR,
         pathname=__file__,
         lineno=1,
@@ -178,6 +178,24 @@ def test_sqlite_locked_log_filter_ignores_non_operational_errors():
         assert filter_.filter(record) is True
 
 
+def test_sqlite_locked_log_filter_works_for_docket_worker_logger():
+    """Test that the filter also suppresses SQLite lock errors from docket.worker logger.
+
+    This is important because docket background tasks (like mark_deployments_ready)
+    can hit SQLite locking issues and log errors through the docket.worker logger.
+    See: https://github.com/PrefectHQ/prefect/issues/19771
+    """
+    filter_ = _SQLiteLockedOperationalErrorFilter()
+    orig_exc = sqlite3.OperationalError(SQLITE_LOCKED_MSG)
+    record = _log_record_for_sqlite_error(orig_exc, logger_name="docket.worker")
+
+    with temporary_settings({PREFECT_API_LOG_RETRYABLE_ERRORS: False}):
+        assert filter_.filter(record) is False
+
+    with temporary_settings({PREFECT_API_LOG_RETRYABLE_ERRORS: True}):
+        assert filter_.filter(record) is True
+
+
 @pytest.mark.parametrize(
     "exc",
     (