feat(product tours): click element to advance to next step #2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
17 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+243
to
+249
| const handleSpotlightClick = (e: MouseEvent) => { | ||
| e.stopPropagation() | ||
| if (targetElement) { | ||
| targetElement.click() | ||
| } | ||
| onNext() | ||
| } |
Contributor
There was a problem hiding this comment.
logic: onNext() called synchronously after targetElement.click() may cause race condition. The click event hasn't fully propagated yet (event bubbling, async handlers, DOM updates). While retry logic exists, consider adding a small delay:
Suggested change
| const handleSpotlightClick = (e: MouseEvent) => { | |
| e.stopPropagation() | |
| if (targetElement) { | |
| targetElement.click() | |
| } | |
| onNext() | |
| } | |
| const handleSpotlightClick = (e: MouseEvent) => { | |
| e.stopPropagation() | |
| if (targetElement) { | |
| targetElement.click() | |
| } | |
| // Give click event time to propagate before advancing | |
| setTimeout(onNext, 0) | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browser/src/extensions/product-tours/components/ProductTourTooltip.tsx
Line: 243:249
Comment:
**logic:** `onNext()` called synchronously after `targetElement.click()` may cause race condition. The click event hasn't fully propagated yet (event bubbling, async handlers, DOM updates). While retry logic exists, consider adding a small delay:
```suggestion
const handleSpotlightClick = (e: MouseEvent) => {
e.stopPropagation()
if (targetElement) {
targetElement.click()
}
// Give click event time to propagate before advancing
setTimeout(onNext, 0)
}
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Contributor
|
Size Change: +785 B (+0.01%) Total Size: 5.26 MB
ℹ️ View Unchanged
|
lucasheriques
approved these changes
Dec 17, 2025
graphite-app
bot
changed the base branch from
12-12-fix_lazy-load_more_of_product_tours
to
graphite-base/2783
adboio
force-pushed
the
12-16-feat_product_tours_click_element_to_advance_to_next_step
branch
from
ebd514c to
88ad02a
Compare
adboio
force-pushed
the
graphite-base/2783
branch
from
dfd885f to
c2ce7ca
Compare
adboio
changed the base branch from
graphite-base/2783
to
12-12-fix_lazy-load_more_of_product_tours
adboio
changed the base branch from
12-12-fix_lazy-load_more_of_product_tours
to
graphite-base/2783
adboio
force-pushed
the
12-16-feat_product_tours_click_element_to_advance_to_next_step
branch
from
88ad02a to
8a11136
Compare
adboio
force-pushed
the
graphite-base/2783
branch
from
c2ce7ca to
ee5e76d
Compare
adboio
force-pushed
the
12-16-feat_product_tours_click_element_to_advance_to_next_step
branch
from
8a11136 to
f145e2c
Compare
Contributor
Author
adboio
deleted the
12-16-feat_product_tours_click_element_to_advance_to_next_step
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
product tours only support progression through a "next" button, which means you cannot build a tour that requires any user interaction (e.g. opening a drawer or modal, etc)
Changes
adds support for a new
click-type trigger that will progress the tour when the target element is clicked. after click, the tour waits up to 2s for the next step's element to be visible.also:
exact(PR to add this note in main repo coming soon)product-tour-click-action.mp4 (uploaded via Graphite)
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file