feat(product tours): surveys for product tours #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
from
94ed5b5 to
381f70f
Compare
Contributor
Contributor
|
Size Change: +6.72 kB (+0.13%) Total Size: 5.27 MB
ℹ️ View Unchanged
|
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
4 times, most recently
from
6445baf to
17f1a70
Compare
17 tasks
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
from
17f1a70 to
f423c3b
Compare
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
from
eb44749 to
8924d3f
Compare
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
from
8924d3f to
1bde42e
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| const tourId = this._activeTour.id | ||
| const step = this._activeTour.steps[this._currentStepIndex] | ||
| const surveyId = step.linkedSurveyId |
Contributor
There was a problem hiding this comment.
logic: step.linkedSurveyId could be undefined when step.survey exists
Suggested change
| const surveyId = step.linkedSurveyId | |
| const surveyId = step.linkedSurveyId || 'unknown' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browser/src/extensions/product-tours/product-tours.tsx
Line: 496:496
Comment:
**logic:** `step.linkedSurveyId` could be undefined when `step.survey` exists
```suggestion
const surveyId = step.linkedSurveyId || 'unknown'
```
How can I resolve this? If you propose a fix, please make it concise.| setTimeout(() => inputRef.current?.focus(), 100) | ||
| }, []) | ||
|
|
||
| const handleKeyDown = (e: KeyboardEvent) => { |
Contributor
There was a problem hiding this comment.
syntax: type mismatch - event type in Preact should be h.JSX.TargetedKeyboardEvent<HTMLTextAreaElement>
Suggested change
| const handleKeyDown = (e: KeyboardEvent) => { | |
| const handleKeyDown = (e: h.JSX.TargetedKeyboardEvent<HTMLTextAreaElement>) => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browser/src/extensions/product-tours/components/ProductTourSurveyStep.tsx
Line: 58:58
Comment:
**syntax:** type mismatch - event type in Preact should be `h.JSX.TargetedKeyboardEvent<HTMLTextAreaElement>`
```suggestion
const handleKeyDown = (e: h.JSX.TargetedKeyboardEvent<HTMLTextAreaElement>) => {
```
How can I resolve this? If you propose a fix, please make it concise.
adboio
changed the title
adboio
changed the title
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
2 times, most recently
from
16a783f to
bc36c4c
Compare
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
from
bc36c4c to
88e4929
Compare
17 tasks
adboio
force-pushed
the
12-11-fix_product_tours_init_surveys_when_required
branch
from
88e4929 to
fe91f75
Compare
17 tasks
lucasheriques
approved these changes
Dec 17, 2025
Contributor
Author
adboio
deleted the
12-11-fix_product_tours_init_surveys_when_required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
build tour-specific survey components
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file