Conversation
Unless `overwrite = TRUE`, don't extract met for years for which every required target file is present. This should make `met2model.ED2` run much faster when extending an existing met record.
ED: Make met2model entirely skip complete years
Use Xenial for Travis build
ED2: Allow negative numbers in custom ED2IN tag vectors
Fix meta-analysis = AUTO bug, and other PEcAn.DB cleanup
- add link to register for database sync ID
this should fix history
…nto ERA_do_conversion
…nto ERA_do_conversion
For the most part, this means unquoting (`!!`) local variables in `dplyr::filter` statements pointing at remote connections. I.e. This: ``` myvalue <- 3 tbl(con, "mytable") %>% filter(column = myvalue) ``` ...should become this: ``` tbl(con, "mytable") %>% filter(column = !!myvalue) ```
…/pecan into biocro_model_info
Apply Alexey's Dbplyr fixes + NAMESPACE changes
Add Setaria as genus for running BioCro
Adding ERA5 to met.process
Member
|
When posting the release notes,
|
dlebauer
approved these changes
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
package::function) throughoutPEcAn.meta.analysis. Otherwise, many of these functions would fail when trying to run a meta-analysis outside of the PEcAn workflow (i.e. without having loaded the packages first) (PEcAn.DBandPEcAn.meta.analysiscleanup #2351).PEcAn.DBtests create database connections, and make sure tests work with both the newerPostgresand olderPostgreSQLdrivers (PEcAn.DBandPEcAn.meta.analysiscleanup #2351).rlang::UQsyntax with the recommended!!PEcAn.uncertainty::read.ensemble.outputinPEcAn.utils::get.results. Otherwise, it would sometimes use the deprecatedPEcAn.utils::read.ensemble.outputversion.Changed
release, the current public release of R (currently R 3.5). Build failures in this version are fixed before merging the change that caused them. When we say PEcAn is fully tested and working, this is the build we mean.devel, the newest available development build of R. We will fix issues with this version before the next major R release.oldrel, the previous major release of R (currently R 3.4). We will fix issues with this version as time allows, but we do not guarantee that it will stay compatible.PEcAn.utils:scripts/generate_dependencies.Ris now used to generate dependencies for make and dockerPEcAn.DB::get.trait.data, iftrait.namesisNULLor missing, use the traits for which at least one prior is available among the input list of PFTs. (Previously, we were getting this from thePEcAn.utils::trait.dictionary, which we are trying to deprecate remove base/utils/data/trait.dictionary.csv #1747). (PEcAn.DBandPEcAn.meta.analysiscleanup #2351)PEcAn.DBrelated to getting trait data, including replacing many manual database queries withdplyrcalls.Added
met2model.<MODEL>functions for most models.RPostgres::Postgresbackend. The backend is officially supported bydb.query, and basic workflows run top-to-bottom with thePostgresbackend. However,RPostgreSQLis still the default until we do more robust testing of all modules.PEcAn.DB::db.querynow optionally supports prepared statements (check for sql injection paths; switch to using prepared sql statements (dplyr?) #395).PEcAn.DB::query_priorsthat expands the functionality ofquery.priorsby (1) accepting PFTs by name or ID and (2) allowing the user to request all possible combinations of the input PFTs and traits (i.e.expand.grid(pfts, traits)) or just the pairwise combinations (i.e.pft[1]-trait[1], pft[2]-trait[2]). This function also comes with more robust error handling and a set of unit tests (PEcAn.DBandPEcAn.meta.analysiscleanup #2351).PEcAn.DB::query_pftsfor finding PFT IDs and types from the PFT name and (optionally) model type (PEcAn.DBandPEcAn.meta.analysiscleanup #2351).PEcAn.DBandPEcAn.meta.analysiscleanup #2351).PEcAn.utils::load_localreadsRdatafiles into a named list (instead of into the current environment).Removed
PEcAn.visualization::points2county, thus removing many indirect dependencies by no longer importing theearthpackage.PEcAn.data.miningfrom the Make build. It can still be installed directly from R if desired, but is skipped by default because it is in early development, does not yet export any functions, and creates a dependency on the (large, often annoying to install) ImageMagick library.MySQLdatabase driver. Now, onlyPostgreSQL(and, experimentally,RPostgres) are supported. With this, removeRMySQLdependency in several places.Fixed
rlang::UQsyntax with the recommended!!PEcAn.uncertainty::read.ensemble.outputinPEcAn.utils::get.results. Otherwise, it would sometimes use the deprecatedPEcAn.utils::read.ensemble.outputversion.PEcAn.ED2::met2model.ED2now skips processing of years for which all output files are already present (unlessoverwrite = TRUE). This prevents a lot of unnecessary work when extending an existing ED met record.