Travis: Build against multiple R versions#2281
Merged
mdietze merged 11 commits intoPecanProject:developfrom Feb 8, 2019
Merged
Travis: Build against multiple R versions#2281mdietze merged 11 commits intoPecanProject:developfrom
mdietze merged 11 commits intoPecanProject:developfrom
Conversation
- RSQlite and data.table, needed by db - gap, needed by assim.batch - sirt and sf, needed by data.land
mdietze
approved these changes
Feb 8, 2019
Member
Author
|
@mdietze I may not have made the "opinions, please" section prominent enough. Should I take your approval to also be an endorsement of allowing failures in oldrel and devel? |
Member
|
Yep, I endorse your approach, but didn’t pull yet so as to give others time to comment. Given how some packages change, it may be impossible to support multiple versions without code that detects which version is installed and switches among different code blocks, and that could become a nightmare |
robkooper
approved these changes
Feb 8, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make checknow skips rebuilding documentation if env var$REBUILD_DOCSis falseMotivation and Context
R versions
The major change here is a transition from testing against one R version (hopefully the one most users have) to defining a build matrix so that we can test in multiple environments at once. The build matrix concept could be extended in the future to include different OSes, Postgres versions, environment variables, etc, but for this PR the matrix is one-dimensional and contains three R versions:
release,devel, andoldrel. These are aliases defined by Travis and currently point respectively to R 3.5, nightly, and 3.4, but versions are updated each release.Opinions, please: I currently have the devel and oldrel builds marked as
allow_failures, which means the build is always run on all three versions, but will report success as long as it finishes successfully on R-release. My rationale is that this will let us keep an eye on how it's doing in other versions but won't commit us to maintaining them. Is this what we want?Skip documentation
I've updated
scripts/check_with_errors.Rto recognize an environment variable$REBUILD_DOCSand pass its logical value to thedocumentargument ofdevtools::check. This is primarily to save a few seconds per package on Travis, where documentation is always freshly-built at check time, but feel free to use it any other timemake checkfails to document/not document things the way you want.Review Time Estimate
Types of changes
Checklist: