Skip to content

python313Packages.pybind11: 2.13.6 -> 3.0.1 #442242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilazy merged 3 commits into from
Sep 15, 2025
Merged

python313Packages.pybind11: 2.13.6 -> 3.0.1 #442242

emilazy merged 3 commits into from
Sep 15, 2025

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Sep 12, 2025 •
edited
Loading

Based on #419220, with working tests and a patch version bump, and rebased after #431558.

@doronbehar Thanks for your work on this! Hope you don’t mind me building on it here – I’ve built a fair amount of stuff with this without issues. I squashed a few of your commits together along with my fixes, as #431558 made them tricky to disentangle. Happily, it seems like all of the tests pass now, at least for me on Darwin.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

emilazy and others added 2 commits September 12, 2025 01:18
@emilazy
python313Packages.scikit-build-core: fix cmakeFlags
7c98af3 
This was broken when using multiple `cmakeFlags` without
`__structuredAttrs`, because `args+=($cmakeFlags)` wouldn’t split
it on whitespace. Let’s do something much cleaner instead.
@doronbehar @emilazy
python313Packages.pybind11: no with lib; in meta
6fe4137
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Sep 12, 2025
@LunNova
Copy link
Member

LunNova commented Sep 12, 2025 •
edited
Loading

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442242 --package python3Packages.pybind11-protobuf --package python3Packages.scikit-build-core --package python3Packages.onnx --package python3Packages.matplotlib --package python3Packages.pybind11 --package python3Packages.pybind11-abseil
Commit: 9d8e2cb75f69d5185addd49294ff101c2d57d33e

x86_64-linux

✅ 10 packages built:
  • python3Packages.matplotlib
  • python3Packages.matplotlib.dist (python3Packages.matplotlib.dist.dist)
  • python3Packages.onnx
  • python3Packages.onnx.dist (python3Packages.onnx.dist.dist)
  • python3Packages.pybind11
  • python3Packages.pybind11-abseil
  • python3Packages.pybind11-protobuf
  • python3Packages.pybind11.dist (python3Packages.pybind11.dist.dist)
  • python3Packages.scikit-build-core
  • python3Packages.scikit-build-core.dist (python3Packages.scikit-build-core.dist.dist)

dotlambda
dotlambda reviewed Sep 12, 2025
View reviewed changes
doronbehar
doronbehar approved these changes Sep 13, 2025
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, so besides @dotlambda's comments this is good to go on my part.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 13, 2025
@GaetanLepage GaetanLepage mentioned this pull request Sep 13, 2025
Closed
13 tasks
@emilazy
Copy link
Member Author

emilazy commented Sep 14, 2025

One slightly weird thing here: we do checkPhase = "ninjaCheckPhase";, but that is actually installCheckPhase because Python, but ninjaCheckPhase of course does runHook preCheck and runHook postCheck. Not sure that’s a problem – you can achieve similar results by reordering the phases, anyway – but thought I should note it.

GaetanLepage
GaetanLepage approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @emilazy!

@dotlambda dotlambda mentioned this pull request Sep 15, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 15, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Sep 15, 2025
@emilazy emilazy merged commit 03342da into NixOS:staging Sep 15, 2025
31 of 33 checks passed
@emilazy emilazy deleted the push-ykpzsmutyopw branch September 15, 2025 21:43
@qbisi qbisi mentioned this pull request Sep 25, 2025
Closed
13 tasks
@dotlambda dotlambda mentioned this pull request Oct 4, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

@doronbehar doronbehar doronbehar approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilazy @LunNova @dotlambda @doronbehar @GaetanLepage