Skip to content

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jun 23, 2025

Description of changes

Preparing for the version 3 release, I found a few fixes that are relevant even for version 2. Currently the build fails with:

Executing pytestCheckPhase
pytest flags: -m pytest
Traceback (most recent call last):
  File "/build/source/tests/conftest.py", line 25, in <module>
    import pybind11_tests
ModuleNotFoundError: No module named 'pybind11_tests'
ImportError while loading conftest '/build/source/tests/conftest.py'.
tests/conftest.py:25: in <module>
    import pybind11_tests
E   ModuleNotFoundError: No module named 'pybind11_tests'

See also:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@doronbehar doronbehar requested a review from dotlambda June 23, 2025 10:46
@github-actions github-actions bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 23, 2025
@doronbehar doronbehar force-pushed the pkg/pybind11@master branch from 8f98ef5 to 05b3375 Compare July 11, 2025 16:18
@dotlambda dotlambda changed the title python312Packages.pybind11: 2.13.6 -> 3.0.0rc4 python312Packages.pybind11: 2.13.6 -> 3.0.0 Jul 11, 2025
@doronbehar doronbehar force-pushed the pkg/pybind11@master branch from 05b3375 to 8896bad Compare July 17, 2025 06:30
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2025
@onny
Copy link
Contributor

onny commented Aug 24, 2025

pybind11 3.0.1 released https://github.com/pybind/pybind11/releases/tag/v3.0.1

@GaetanLepage
Copy link
Contributor

Opened #438171 to introduce pybind11_3, as an alternative to pybind11_2 which would remain the default version.
We could then handle the global migration to pybind11_3 in a second time.

@dotlambda
Copy link
Member

Opened #438171 to introduce pybind11_3, as an alternative to pybind11_2 which would remain the default version. We could then handle the global migration to pybind11_3 in a second time.

Do we actually know of any packages that don't build with pybind11 v3, and not just because they pin the version?

@chpatrick
Copy link
Contributor

Opened #438171 to introduce pybind11_3, as an alternative to pybind11_2 which would remain the default version. We could then handle the global migration to pybind11_3 in a second time.

Do we actually know of any packages that don't build with pybind11 v3, and not just because they pin the version?

I think it would be nice to have >=3.0.0 available already for packages that need it (like COLMAP), before we sort out whether those packages really need 2.0 or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants